Address PR feedbacks

Author: tkan145

gateway/src/apicast/configuration_loader/remote_v2.lua

@@ -120,6 +120,8 @@ local function parse_proxy_configs(self, proxy_configs)
     if issuer_endpoint then
       oidc = self.oidc:call(issuer_endpoint, self.ttl)
     end
+    -- We always assign a oidc to the service, even an empty one with the
+    -- service_id, if not on APICAST_SERVICES_LIST will fail on filtering
     if not oidc then
       oidc = {}
     end
@@ -452,10 +454,6 @@ function _M:services()
   return services
 end
 
-function _M:oidc_issuer_configuration(service)
-  return self.oidc:call(service.oidc.issuer_endpoint, self.ttl)
-end
-
 function _M:config(service, environment, version, service_regexp_filter)
   local http_client = self.http_client
 

gateway/src/apicast/policy_chain.lua

@@ -199,7 +199,7 @@ local default_policy_order_check = PolicyOrderChecker.new(policy_manifests_loade
 -- It doesn't return anything, it prints error messages when there's a problem.
 function _M:check_order(manifests)
   if manifests then
-    PolicyOrderChecker.new(manifests):check(self)
+    return PolicyOrderChecker.new(manifests):check(self)
   end
   default_policy_order_check:check(self)
 end

gateway/src/apicast/policy_loader.lua

@@ -16,10 +16,10 @@ local concat = table.concat
 local setmetatable = setmetatable
 local pcall = pcall
 
-local tab_new = require('table.new')
 local isempty = require('table.isempty')
 
-local manifests_cache = tab_new(32, 0)
+-- Module-level cache storage (one per worker process)
+local manifests_cache = {}
 
 local _M = {}
 
@@ -75,7 +75,11 @@ local function lua_load_path(load_path)
   return format('%s/?.lua', load_path)
 end
 
-local function get_manifest(name, version)
+-- Get a cached manifest by policy name and version
+-- @tparam string name The policy name
+-- @tparam string version The policy version
+-- @treturn table|nil The cached manifest table, or nil if not cached
+local function get_cached_manifest(name, version)
   local manifests = manifests_cache[name]
   if manifests then
     for _, manifest in ipairs(manifests) do
@@ -87,7 +91,7 @@ local function get_manifest(name, version)
 end
 
 local function load_manifest(name, version, path)
-  local manifest = get_manifest(name, version)
+  local manifest = get_cached_manifest(name, version)
   if not manifest then
     manifest = read_manifest(path)
   end

spec/configuration_loader/remote_v2_spec.lua

@@ -651,7 +651,7 @@ UwIDAQAB
     it('does not crash on empty issuer', function()
       local service = { oidc = { issuer_endpoint = '' }}
 
-      assert.falsy(loader:oidc_issuer_configuration(service))
+      assert.falsy(loader.oidc:call(service.oidc.issuer_endpoint, 0))
     end)
   end)