From 236c2d7f10cbbf00c6d8e45b831ccddde1644caa Mon Sep 17 00:00:00 2001 From: Andrei Fateev Date: Wed, 10 Jun 2026 18:00:00 +0200 Subject: [PATCH 1/3] feat: fix a11y issues in progress linear component --- playwright/cps-accessibility.spec.ts | 10 ++++----- .../src/app/api-data/cps-progress-linear.json | 8 +++++++ .../progress-linear-page.component.html | 14 ++++++------- .../progress-linear-page.component.scss | 2 +- .../cps-autocomplete.component.html | 4 ++-- .../cps-input/cps-input.component.html | 4 ++-- .../cps-progress-linear.component.html | 1 + .../cps-progress-linear.component.spec.ts | 21 +++++++++++++++++++ .../cps-progress-linear.component.ts | 19 +++++++++++++---- .../cps-select/cps-select.component.html | 4 ++-- .../cps-tree-autocomplete.component.html | 4 ++-- .../cps-tree-select.component.html | 4 ++-- 12 files changed, 68 insertions(+), 27 deletions(-) diff --git a/playwright/cps-accessibility.spec.ts b/playwright/cps-accessibility.spec.ts index 55d8be9ed..dfaa3ac1e 100644 --- a/playwright/cps-accessibility.spec.ts +++ b/playwright/cps-accessibility.spec.ts @@ -155,11 +155,11 @@ const components: ComponentEntry[] = [ // name: 'Progress circular', // selector: 'cps-progress-circular' // }, - // { - // route: '/progress-linear', - // name: 'Progress linear', - // selector: 'cps-progress-linear' - // }, + { + route: '/progress-linear', + name: 'Progress linear', + selector: 'cps-progress-linear' + }, { route: '/radio-group', name: 'Radio', selector: 'cps-radio-group' }, { route: '/scheduler', diff --git a/projects/composition/src/app/api-data/cps-progress-linear.json b/projects/composition/src/app/api-data/cps-progress-linear.json index 0d2c554c3..55cc608b0 100644 --- a/projects/composition/src/app/api-data/cps-progress-linear.json +++ b/projects/composition/src/app/api-data/cps-progress-linear.json @@ -52,6 +52,14 @@ "type": "string | number", "default": "0", "description": "Border radius of the progress bar, of type number denoting pixels or string." + }, + { + "name": "ariaLabel", + "optional": false, + "readonly": false, + "type": "string", + "default": "Loading", + "description": "Accessible label announced by screen readers to describe what is loading." } ] } diff --git a/projects/composition/src/app/pages/progress-linear-page/progress-linear-page.component.html b/projects/composition/src/app/pages/progress-linear-page/progress-linear-page.component.html index d95d8bcc1..9366a925d 100644 --- a/projects/composition/src/app/pages/progress-linear-page/progress-linear-page.component.html +++ b/projects/composition/src/app/pages/progress-linear-page/progress-linear-page.component.html @@ -4,21 +4,21 @@ + height="0.75rem"> + width="25rem" + height="0.75rem"> diff --git a/projects/composition/src/app/pages/progress-linear-page/progress-linear-page.component.scss b/projects/composition/src/app/pages/progress-linear-page/progress-linear-page.component.scss index 056d4b431..60eaa669a 100644 --- a/projects/composition/src/app/pages/progress-linear-page/progress-linear-page.component.scss +++ b/projects/composition/src/app/pages/progress-linear-page/progress-linear-page.component.scss @@ -1,5 +1,5 @@ .progr-lin-group { - gap: 48px; + gap: 3rem; display: flex; flex-direction: column; } diff --git a/projects/cps-ui-kit/src/lib/components/cps-autocomplete/cps-autocomplete.component.html b/projects/cps-ui-kit/src/lib/components/cps-autocomplete/cps-autocomplete.component.html index e9201d4fe..2d80187dd 100644 --- a/projects/cps-ui-kit/src/lib/components/cps-autocomplete/cps-autocomplete.component.html +++ b/projects/cps-ui-kit/src/lib/components/cps-autocomplete/cps-autocomplete.component.html @@ -295,8 +295,8 @@ @if (loading || validating) { diff --git a/projects/cps-ui-kit/src/lib/components/cps-input/cps-input.component.html b/projects/cps-ui-kit/src/lib/components/cps-input/cps-input.component.html index 2e083ea00..50dbaf677 100644 --- a/projects/cps-ui-kit/src/lib/components/cps-input/cps-input.component.html +++ b/projects/cps-ui-kit/src/lib/components/cps-input/cps-input.component.html @@ -141,8 +141,8 @@ } @if (loading) { diff --git a/projects/cps-ui-kit/src/lib/components/cps-progress-linear/cps-progress-linear.component.html b/projects/cps-ui-kit/src/lib/components/cps-progress-linear/cps-progress-linear.component.html index e2cae6e79..54ab2d2cf 100644 --- a/projects/cps-ui-kit/src/lib/components/cps-progress-linear/cps-progress-linear.component.html +++ b/projects/cps-ui-kit/src/lib/components/cps-progress-linear/cps-progress-linear.component.html @@ -1,4 +1,5 @@