-
Notifications
You must be signed in to change notification settings - Fork 485
Open
Labels
Modernise (C++17)Needs DiscussionNeeds discussion before implmentation, which could result in changes, or a decision not to proceed.Needs discussion before implmentation, which could result in changes, or a decision not to proceed.dependenciesPull requests that update a dependency filePull requests that update a dependency file
Description
Our current usage of pystring falls into 2 camps
String manipulation e.g. split, startswith, endswith, splitlines, lstrip etc
Filesystem interaction pystring::os::*
I would propose that this be carried out in 3 stages:
- Replace string functionality with code based on our own StringUtils (add functionality where needed). We already have some tests for replacing the split() behaviour for example.
- Replace filesystem interaction by calls to std::filesystem (C++17)
- Remove all pystring from CMake
Metadata
Metadata
Assignees
Labels
Modernise (C++17)Needs DiscussionNeeds discussion before implmentation, which could result in changes, or a decision not to proceed.Needs discussion before implmentation, which could result in changes, or a decision not to proceed.dependenciesPull requests that update a dependency filePull requests that update a dependency file