From a9c90a0a31437afd0b839b7a481f7deece91ffdd Mon Sep 17 00:00:00 2001 From: UnschooledGamer <76094069+UnschooledGamer@users.noreply.github.com> Date: Thu, 9 Apr 2026 12:05:40 +0530 Subject: [PATCH 1/2] chore(CI): force Node24 for JS actions and use env APK paths Set FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 for JS-based actions to avoid GitHub Actions Node 20 deprecation. Add NORMAL_APK_PATH and FDROID_APK_PATH env vars and use them for building, uploading, and releasing APKs. Also fix STORE_FILE_PATH/BUILD_JSON_PATH expansions and add debug echo lines. --- .../workflows/community-release-notifier.yml | 6 +++++ .github/workflows/nightly-build.yml | 22 ++++++++++++------- 2 files changed, 20 insertions(+), 8 deletions(-) diff --git a/.github/workflows/community-release-notifier.yml b/.github/workflows/community-release-notifier.yml index 06d87eb9e..d8f320fdf 100644 --- a/.github/workflows/community-release-notifier.yml +++ b/.github/workflows/community-release-notifier.yml @@ -89,6 +89,9 @@ jobs: - name: Truncate message for Discord id: truncate-discord uses: 2428392/gh-truncate-string-action@b3ff790d21cf42af3ca7579146eedb93c8fb0757 # v1.4.1 + env: + # https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/ + FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true with: maxLength: 2000 stringToTruncate: | @@ -101,6 +104,9 @@ jobs: # ──────────────────────────────────────────────── - name: Discord Webhook (Publishing) uses: tsickert/discord-webhook@b217a69502f52803de774ded2b1ab7c282e99645 # v7.0.0 + env: + # https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/ + FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true with: webhook-url: ${{ secrets.DISCORD_WEBHOOK_RELEASE_NOTES }} content: ${{ steps.truncate-discord.outputs.string }} diff --git a/.github/workflows/nightly-build.yml b/.github/workflows/nightly-build.yml index 0ecfffa89..293bb8d3f 100644 --- a/.github/workflows/nightly-build.yml +++ b/.github/workflows/nightly-build.yml @@ -50,6 +50,8 @@ BUILD_JSON_PATH: build.json VERSION_LABEL: ${{ (inputs.is_PR && 'pr') || 'nightly' }} DISCORD_RELEASE_NOTIFIER_ENABLED: "true" + NORMAL_APK_PATH: /tmp/acode-debug-normal-${{ env.UPDATED_VERSION }}.apk + FDROID_APK_PATH: /tmp/acode-debug-fdroid-${{ env.UPDATED_VERSION }}.apk jobs: build: timeout-minutes: 60 @@ -87,6 +89,8 @@ echo "env: VERSION_LABEL: ${{ env. VERSION_LABEL }}" echo "github sha: ${{ github.sha }}" echo "should not skip tags, releases: ${{ ! inputs.skip_tagging_and_releases }} " + echo "🤐 env: NORMAL_APK_PATH: ${{ env.NORMAL_APK_PATH }}" + echo "🤐 env: FDROID_APK_PATH: ${{ env.FDROID_APK_PATH }}" echo "::endgroup::" echo "## 🚀 Build Type: ${{ env.VERSION_LABEL }}" >> $GITHUB_STEP_SUMMARY @@ -117,8 +121,8 @@ - name: Add keystore and build.json from secrets run: | - echo "${{ secrets.KEYSTORE_CONTENT }}" | base64 -d > $STORE_FILE_PATH - echo "${{ secrets.BUILD_JSON_CONTENT }}" | base64 -d > $BUILD_JSON_PATH + echo "${{ secrets.KEYSTORE_CONTENT }}" | base64 -d > ${{ env.STORE_FILE_PATH }} + echo "${{ secrets.BUILD_JSON_CONTENT }}" | base64 -d > ${{ env.BUILD_JSON_PATH }} echo "Keystore and build.json added successfully." - name: Export Commit Hash & prev tag @@ -172,28 +176,28 @@ run: | node utils/storage_manager.mjs y npm run build paid dev apk - mv platforms/android/app/build/outputs/apk/debug/app-debug.apk /tmp/acode-debug-normal-$UPDATED_VERSION.apk + mv platforms/android/app/build/outputs/apk/debug/app-debug.apk ${{ env.NORMAL_APK_PATH }} echo "VERSION: $UPDATED_VERSION" >> $GITHUB_STEP_SUMMARY - name: Upload APK Artifact uses: actions/upload-artifact@v7 with: name: app-debug-${{ env.GIT_COMMIT }} - path: /tmp/acode-debug-normal-${{ env.UPDATED_VERSION }}.apk + path: ${{ env.NORMAL_APK_PATH }} - name: Run npm build paid dev apk fdroid (for F-Droid) if: ${{ !inputs.is_PR }} run: | node utils/storage_manager.mjs y npm run build paid dev apk fdroid - mv platforms/android/app/build/outputs/apk/debug/app-debug.apk /tmp/acode-debug-fdroid-$UPDATED_VERSION.apk + mv platforms/android/app/build/outputs/apk/debug/app-debug.apk ${{ env.FDROID_APK_PATH }} - name: Upload APK Artifact uses: actions/upload-artifact@v7 if: ${{ !inputs.is_PR }} with: name: app-debug-fdroid-${{ env.GIT_COMMIT }} - path: /tmp/acode-debug-fdroid-${{ env.UPDATED_VERSION }}.apk + path: ${{ env.FDROID_APK_PATH }} - name: remove keystore and build.json run: | @@ -246,13 +250,15 @@ id: release if: ${{ ! inputs.skip_tagging_and_releases && steps.check-nightly-tag-force-update.outcome == 'success' && env.releaseRequired == 'true' && !inputs.is_PR }} uses: softprops/action-gh-release@v2 + env: + FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true with: prerelease: true name: ${{ env.UPDATED_VERSION }} tag_name: ${{ env.UPDATED_VERSION }} files: | - /tmp/acode-debug-normal-$UPDATED_VERSION.apk - /tmp/acode-debug-fdroid-$UPDATED_VERSION.apk + ${{ env.NORMAL_APK_PATH }} + ${{ env.FDROID_APK_PATH }} body: | Automated Nightly (pre-release) Releases for Today From 75fcb156ffd5e8377153ffa3b947db8faf05ae3c Mon Sep 17 00:00:00 2001 From: UnschooledGamer <76094069+UnschooledGamer@users.noreply.github.com> Date: Thu, 9 Apr 2026 12:42:20 +0530 Subject: [PATCH 2/2] fix(CI): NORMAL_APK_PATH and paths being partially empty --- .github/workflows/nightly-build.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/nightly-build.yml b/.github/workflows/nightly-build.yml index 293bb8d3f..b959670ab 100644 --- a/.github/workflows/nightly-build.yml +++ b/.github/workflows/nightly-build.yml @@ -50,8 +50,6 @@ BUILD_JSON_PATH: build.json VERSION_LABEL: ${{ (inputs.is_PR && 'pr') || 'nightly' }} DISCORD_RELEASE_NOTIFIER_ENABLED: "true" - NORMAL_APK_PATH: /tmp/acode-debug-normal-${{ env.UPDATED_VERSION }}.apk - FDROID_APK_PATH: /tmp/acode-debug-fdroid-${{ env.UPDATED_VERSION }}.apk jobs: build: timeout-minutes: 60 @@ -161,7 +159,9 @@ echo "Updated version in config.xml" # Output the updated version echo "UPDATED_VERSION=$UPDATED_VERSION" >> $GITHUB_ENV - echo "UPDATED_VERSION=$UPDATED_VERSION" >> $GITHUB_OUTPUT + echo "UPDATED_VERSION=$UPDATED_VERSION" >> $GITHUB_OUTPUT + echo "NORMAL_APK_PATH=/tmp/acode-debug-normal-${UPDATED_VERSION}.apk" >> $GITHUB_ENV + echo "FDROID_APK_PATH=/tmp/acode-debug-fdroid-${UPDATED_VERSION}.apk" >> $GITHUB_ENV - name: Install Node.js Packages run: npm install