DPL GUI: simplify and speed up (#14700)

* Avoid cumbersome retrivial of the lifetime
* No need to create a string just to format it.

Author: ktf

Framework/GUISupport/CMakeLists.txt

@@ -20,6 +20,7 @@ o2_add_library(FrameworkGUISupport
                        src/PaletteHelpers.cxx
                        src/SpyService.cxx
                        src/SpyServiceHelpers.cxx
+                       src/InspectorHelpers.cxx
                PRIVATE_INCLUDE_DIRECTORIES ${CMAKE_CURRENT_LIST_DIR}/src
                PUBLIC_LINK_LIBRARIES O2::Framework AliceO2::DebugGUI)
 

Framework/GUISupport/src/FrameworkGUIDataRelayerUsage.cxx

@@ -233,7 +233,7 @@ void displayDataRelayer(DeviceMetricsInfo const& /*metrics*/,
         continue;
       }
       if (i == (size_t)row) {
-        ImGui::Text("%d %.*s (%s)", row, int(end - input), input, InspectorHelpers::getLifeTimeStr(spec.inputs[i].matcher.lifetime).c_str());
+        ImGui::Text("%d %.*s (%s)", row, int(end - input), input, InspectorHelpers::getLifeTimeStr(spec.inputs[i].matcher.lifetime));
         break;
       }
       ++i;

Framework/GUISupport/src/FrameworkGUIDeviceInspector.cxx

@@ -79,7 +79,8 @@ void deviceStateTable(DataProcessingStates const& states)
   }
 }
 
-void deviceInfoTable(char const* label, ProcessingStateId id, DataProcessingStates const& states, std::variant<std::vector<InputRoute>, std::vector<OutputRoute>> routes, DeviceMetricsInfo const& metrics)
+template <typename Routes>
+void deviceInfoTable(char const* label, ProcessingStateId id, DataProcessingStates const& states, Routes const& routes, DeviceMetricsInfo const& metrics)
 {
   // Find the state spec associated to data_queries
   auto& view = states.statesViews[(int)id];
@@ -95,17 +96,10 @@ void deviceInfoTable(char const* label, ProcessingStateId id, DataProcessingStat
       if ((end - input) == 0) {
         continue;
       }
-      auto getLifetime = [&routes, &i]() -> Lifetime {
-        if (std::get_if<std::vector<InputRoute>>(&routes)) {
-          return std::get<std::vector<InputRoute>>(routes)[i].matcher.lifetime;
-        } else {
-          return std::get<std::vector<OutputRoute>>(routes)[i].matcher.lifetime;
-        }
-      };
-      ImGui::Text("%zu: %.*s (%s)", i, int(end - input), input, InspectorHelpers::getLifeTimeStr(getLifetime()).c_str());
+      ImGui::Text("%zu: %.*s (%s)", i, int(end - input), input, InspectorHelpers::getLifeTimeStr(routes[i].matcher.lifetime));
       if (ImGui::IsItemHovered()) {
         ImGui::BeginTooltip();
-        ImGui::Text("%zu: %.*s (%s)", i, int(end - input), input, InspectorHelpers::getLifeTimeStr(getLifetime()).c_str());
+        ImGui::Text("%zu: %.*s (%s)", i, int(end - input), input, InspectorHelpers::getLifeTimeStr(routes[i].matcher.lifetime));
         ImGui::EndTooltip();
       }
       input = end + 1;
@@ -346,8 +340,8 @@ void displayDeviceInspector(DeviceSpec const& spec,
   }
 
   deviceStateTable(states);
-  deviceInfoTable("Inputs:", ProcessingStateId::DATA_QUERIES, states, std::variant<std::vector<InputRoute>, std::vector<OutputRoute>>(spec.inputs), metrics);
-  deviceInfoTable("Outputs:", ProcessingStateId::OUTPUT_MATCHERS, states, std::variant<std::vector<InputRoute>, std::vector<OutputRoute>>(spec.outputs), metrics);
+  deviceInfoTable("Inputs:", ProcessingStateId::DATA_QUERIES, states, spec.inputs, metrics);
+  deviceInfoTable("Outputs:", ProcessingStateId::OUTPUT_MATCHERS, states, spec.outputs, metrics);
   configurationTable(info.currentConfig, info.currentProvenance);
   optionsTable("Workflow Options", metadata.workflowOptions, control);
   if (ImGui::CollapsingHeader("Labels", ImGuiTreeNodeFlags_DefaultOpen)) {

Framework/GUISupport/src/InspectorHelpers.cxx

@@ -0,0 +1,40 @@
+// Copyright 2019-2025 CERN and copyright holders of ALICE O2.
+// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
+// All rights not expressly granted are reserved.
+//
+// This software is distributed under the terms of the GNU General Public
+// License v3 (GPL Version 3), copied verbatim in the file "COPYING".
+//
+// In applying this license CERN does not waive the privileges and immunities
+// granted to it by virtue of its status as an Intergovernmental Organization
+// or submit itself to any jurisdiction.
+
+#include "InspectorHelpers.h"
+
+namespace o2::framework
+{
+char const* InspectorHelpers::getLifeTimeStr(Lifetime lifetime)
+{
+  switch (lifetime) {
+    case Lifetime::Timeframe:
+      return "Timeframe";
+    case Lifetime::Condition:
+      return "Condition";
+    case Lifetime::Sporadic:
+      return "Sporadic";
+    case Lifetime::Transient:
+      return "Transient";
+    case Lifetime::Timer:
+      return "Timer";
+    case Lifetime::Enumeration:
+      return "Enumeration";
+    case Lifetime::Signal:
+      return "Signal";
+    case Lifetime::Optional:
+      return "Optional";
+    case Lifetime::OutOfBand:
+      return "OutOfBand";
+  }
+  return "none";
+};
+} // namespace o2::framework

Framework/GUISupport/src/InspectorHelpers.h

@@ -1,4 +1,4 @@
-// Copyright 2019-2020 CERN and copyright holders of ALICE O2.
+// Copyright 2019-2025 CERN and copyright holders of ALICE O2.
 // See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
 // All rights not expressly granted are reserved.
 //
@@ -11,39 +11,14 @@
 #ifndef O2_FRAMEWORK_INSPECTORHELPERS_H_
 #define O2_FRAMEWORK_INSPECTORHELPERS_H_
 
-#include <string>
-
 #include "Framework/Lifetime.h"
 
 namespace o2::framework
 {
 
 /// A helper class for inpsection of device information
 struct InspectorHelpers {
-  static const std::string getLifeTimeStr(Lifetime lifetime)
-  {
-    switch (lifetime) {
-      case Lifetime::Timeframe:
-        return "Timeframe";
-      case Lifetime::Condition:
-        return "Condition";
-      case Lifetime::Sporadic:
-        return "Sporadic";
-      case Lifetime::Transient:
-        return "Transient";
-      case Lifetime::Timer:
-        return "Timer";
-      case Lifetime::Enumeration:
-        return "Enumeration";
-      case Lifetime::Signal:
-        return "Signal";
-      case Lifetime::Optional:
-        return "Optional";
-      case Lifetime::OutOfBand:
-        return "OutOfBand";
-    }
-    return "none";
-  };
+  static const char* getLifeTimeStr(Lifetime lifetime);
 };
 
 } // namespace o2::framework