[pull] main from google:main#36
Merged
Merged
Conversation
…0.0 (#1786) * Add Python API docs generation script and Sphinx config * Add Python API reference docs for ADK Python 2.0.0 * Include version and release number in config for built API docs
* Add Redis integration entry Adds an integration catalog entry for `adk-redis` (https://github.com/redis-developer/adk-redis), the Python package that provides Redis-backed ADK integrations: - RedisVL-backed search tools (vector, hybrid, range, text, SQL), including native FT.HYBRID on Redis 8.4+ - Session and long-term memory services that implement BaseSessionService and BaseMemoryService against Redis Agent Memory Server - An McpToolset helper for RedisVL's own MCP server (`rvl mcp`), alongside the existing Agent Memory Server MCP helper - Self-hosted and managed (Redis LangCache) semantic cache providers Built and previewed with `mkdocs build --strict`; the page renders at /integrations/redis/ and appears on the catalog grid. * Minor fixes to Redis integration page * Use ADK's native McpToolset for the RedisVL MCP integration Per maintainer guidance on the PR review thread: - Replace `create_redisvl_mcp_toolset(...)` (a third-party Python wrapper that adk-redis shipped briefly but does not ship in the released 0.0.5) with ADK's native `McpToolset` plus `StdioConnectionParams` + `StdioServerParameters(command="rvl", ...)`. Matches the pattern used by every other MCP catalog page (cartesia, chroma, mongodb, pinecone, qdrant). - Add a `!!! note` admonition pointing readers to `/tools-custom/mcp-tools/` if they want to connect to the `rvl mcp` server from other ADK language SDKs. - Rename the tab from "MCP toolset" to "RedisVL MCP server" and prepend a one-paragraph explanation. - Update the surface table at the top: split the single "MCP toolsets" row into "RedisVL MCP" (native McpToolset against `rvl mcp`) and "AMS MCP toolset" (`create_memory_mcp_toolset`). - Update the "Available tools" table: replace the `create_redisvl_mcp_toolset(...)` helper row with a description of the `rvl mcp` server's exposed tools and how to wire `McpToolset` to them. Other clean-ups: - Drop the `pip install 'adk-redis[mcp-search]'` line; the extra was retired from adk-redis 0.0.5 along with the wrapper. Add a `pip install 'redisvl[mcp]>=0.18.2'` line for the MCP CLI. - Switch sample vectorizer to `redis/langcache-embed-v2`, matching the repo's runnable examples and the rest of the adk-redis docs. Verified with `mkdocs build --strict` locally. The admonition renders; the link to `/tools-custom/mcp-tools/` resolves. * Switch Redis catalog icon to the official Red wordmark SVG The page previously used the Redis org GitHub avatar PNG (460x460, cube mark). Swap to `Redis_Logo_Red_RGB.svg` from the official Redis brand kit (sourced via redis/redis-vl-python), matching the logo used in the adk-redis README hero. SVG is acceptable for catalog assets (see goodmem.svg precedent). Note: this asset is a wordmark (viewBox ~500x156), wider than peer catalog cards which are mostly square. If it renders awkwardly on the catalog grid, swap back to a square cube-mark variant. - Add `docs/integrations/assets/redis.svg`. - Update `catalog_icon` in `redis.md` frontmatter. - Drop `docs/integrations/assets/redis.png`. Verified with `mkdocs build --strict`. * Formatting and minor edits * fix: remove AMS MCP toolset mentions per reviewer feedback Remove create_memory_mcp_toolset() references from the overview table and MCP tools table. This wrapper was removed from adk-redis in v0.0.6 (redis-developer/adk-redis#13). Users should use ADK's native McpToolset with SseConnectionParams for Agent Memory Server MCP access. Resolves comments from @koverholt on lines 29 and 239. * fix: reorder tabs and table to lead with MCP, fix count to four ways * feat: add AMS MCP server tab and MCP table entry Add a separate code tab showing how to connect ADK's native McpToolset to Agent Memory Server's MCP endpoint over SSE, based on the fitness_coach_mcp example. Also add a corresponding row to the MCP reference table. Update overview count to five ways. * fix: rename AMS MCP to Sessions + Memory MCP server * feat: split Semantic cache tab into self-hosted and LangCache Add a separate LangCache tab with accurate code snippet using LangCacheProvider and LangCacheProviderConfig (cache_id, api_key, server_url). No local vectorizer needed for the managed service. * refactor: move semantic caching into its own section Semantic caching is a cross-cutting optimization rather than a core integration approach. Move the self-hosted (RedisVL) and managed (LangCache) cache tabs out of 'Use with agent' into a dedicated '## Semantic caching' section. Drop the cache row from the overview table, leaving four core approaches. * fix: add descriptions to Sessions + Memory and Search tools tabs * fix: semantic search -> hybrid search in Sessions + Memory description * docs: link to adk-redis mkdocs site in additional resources Primary docs link now points to redis-developer.github.io/adk-redis/. The redis.io integration page is kept as a secondary reference. * Remove redundant MCP table - does not show tools; make approaches wording future proof * Readd MCP table with tools and options as before --------- Co-authored-by: Kristopher Overholt <koverholt@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by cubic
Adds Sphinx-based Python API reference for ADK Python 2.0.0 and a Redis integration guide, improving API discoverability and showing how to use Redis for search, sessions/memory, and semantic caching.
tools/python-api-docs/*) to auto-discover modules and build Sphinx HTML.docs/api-reference/python/with version2.0.0./integrations/redis/) and icon, covering RedisVL-backed search tools (redisvl), Sessions + Memory with Redis Agent Memory Server, MCP server usage, and semantic caching (self-hosted and LangCache).Written for commit 04cc351. Summary will update on new commits. Review in cubic