fix(generator): run check-repository for every repo at startup (ACWEB-6)#1
Open
rkkmkkfx wants to merge 2 commits into
Open
fix(generator): run check-repository for every repo at startup (ACWEB-6)#1rkkmkkfx wants to merge 2 commits into
rkkmkkfx wants to merge 2 commits into
Conversation
check-repositories built its result with a lazy map realized only by notifier/complete-sync. The notifier is now a no-op stub, so the map was never realized -> check-repository never ran -> repos kept :git nil and the startup sync silently never happened (staging frozen since 2019; redis jobs hit nil :git -> NPE). Wrap the map in doall to decouple the sync from the notifier. Refs ACWEB-6.
…B-6) update-anychart-versions fetched only /branches, so the editor's AnyChart version dropdown showed branch names (RC-*, feature) but none of the bare release tags (8.8.0..8.14.1). Also fetch /tags and merge; strip the leading v from semver tags (v8.14.1 -> 8.14.1) since cdn.anychart.com/releases/<v>/ is bare (v8.14.1 -> 404, 8.14.1 -> 200). v7/v8 aliases left intact. Refs ACWEB-6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (ACWEB-6, found via live pg-stg inspection)
check-repositoriesbuilds itsresultwith a lazymapthat onlynotifier/complete-syncwould realize. The notifier is now a no-op stub, so the map is never realized →check-repositorynever runs → repos keep:git niland the startup sync silently never happens.Live evidence on pg-stg: DB frozen since 2019; no
Repository "X" - OKlog lines ever; redis{:repo "api"}jobs hit:git nil→NullPointerExceptionloop.Fix
Wrap the
mapindoallsocheck-repository(sets:git, triggers startup sync) runs for every repo, independent of the notifier.Scope
One-line behavior fix in
src/playground/generator/core.clj(check-repositories). No signature change.Not included (tracked in ACWEB-6)
delete-repoFK bug (canonical_visits) — already manually unblocked on staging.released-version?/branches).Verify after deploy (pg-stg,
#pg)Restart pg-stg → expect
Repository "X" - OKlogs, freshversions.create_date, and the editor version list refreshing.