Add V8 API compatibility shims for old-style accessor callbacks

- Add AccessorGetterCallback and AccessorSetterCallback typedefs using
  Local<String> (the old API) to v8-object.h
- Add SetAccessor overloads that accept old-style callbacks and forward
  to SetNativeDataProperty with proper type conversion
- Add <cstring> include for memcpy used in type conversion
- Add nodejs symlink in Dockerfile.Fibers for npm scripts that expect it

This allows node-fibers to compile against Node 24's V8 headers without
modification, as it uses the old SetAccessor API with Local<String> and
AccessorGetterCallback signatures.

Co-Authored-By: Claude (global.anthropic.claude-opus-4-5-20251101-v1:0) <noreply@anthropic.com>

Author: JackStrohm-asana

Dockerfile.Fibers

@@ -27,6 +27,8 @@ ENV PATH="/usr/src/node/node-install/usr/local/bin:$PATH"
 RUN which node
 RUN node -v
 RUN node -p "process.arch"
+# Create nodejs symlink for npm scripts that expect it
+RUN ln -sf /usr/src/node/node-install/usr/local/bin/node /usr/local/bin/nodejs || true
 RUN echo -------------------
 RUN git clone --branch jackstrohm_node20_fibers --depth 1 https://github.com/asana/node-fibers.git node-fibers
 

deps/v8/include/v8-object.h

@@ -5,6 +5,8 @@
 #ifndef INCLUDE_V8_OBJECT_H_
 #define INCLUDE_V8_OBJECT_H_
 
+#include <cstring>  // for memcpy in SetAccessor compatibility shim
+
 #include "v8-internal.h"           // NOLINT(build/include_directory)
 #include "v8-local-handle.h"       // NOLINT(build/include_directory)
 #include "v8-maybe.h"              // NOLINT(build/include_directory)
@@ -159,6 +161,17 @@ using AccessorNameSetterCallback =
     void (*)(Local<Name> property, Local<Value> value,
              const PropertyCallbackInfo<void>& info);
 
+/**
+ * Compatibility shim for node-fibers: Old-style accessor callbacks using
+ * Local<String> instead of Local<Name>. These were removed in V8 12.x.
+ */
+using AccessorGetterCallback =
+    void (*)(Local<String> property, const PropertyCallbackInfo<Value>& info);
+
+using AccessorSetterCallback =
+    void (*)(Local<String> property, Local<Value> value,
+             const PropertyCallbackInfo<void>& info);
+
 /**
  * Access control specifications.
  *
@@ -380,6 +393,29 @@ class V8_EXPORT Object : public Value {
                                  setter_side_effect_type);
   }
 
+  /**
+   * Compatibility shim for node-fibers: Old-style SetAccessor accepting
+   * AccessorGetterCallback (Local<String> based) instead of
+   * AccessorNameGetterCallback (Local<Name> based).
+   */
+  V8_WARN_UNUSED_RESULT Maybe<bool> SetAccessor(
+      Local<Context> context, Local<String> name,
+      AccessorGetterCallback getter,
+      AccessorSetterCallback setter = nullptr,
+      Local<Value> data = Local<Value>(), PropertyAttribute attributes = None,
+      SideEffectType getter_side_effect_type = SideEffectType::kHasSideEffect,
+      SideEffectType setter_side_effect_type = SideEffectType::kHasSideEffect) {
+    // String inherits from Name. Safe type pun since Local is just a pointer.
+    Local<Name> name_as_name;
+    static_assert(sizeof(name_as_name) == sizeof(name), "Local size mismatch");
+    memcpy(&name_as_name, &name, sizeof(name));
+    return SetNativeDataProperty(
+        context, name_as_name,
+        reinterpret_cast<AccessorNameGetterCallback>(getter),
+        reinterpret_cast<AccessorNameSetterCallback>(setter), data, attributes,
+        getter_side_effect_type, setter_side_effect_type);
+  }
+
   /**
    * Attempts to create a property with the given name which behaves like a data
    * property, except that the provided getter is invoked (and provided with the

deps/v8/include/v8-template.h

@@ -6,6 +6,7 @@
 #define INCLUDE_V8_TEMPLATE_H_
 
 #include <cstddef>
+#include <cstring>  // for memcpy in SetAccessor compatibility shim
 #include <string_view>
 
 #include "v8-data.h"               // NOLINT(build/include_directory)
@@ -122,6 +123,28 @@ class V8_EXPORT Template : public Data {
                           getter_side_effect_type, setter_side_effect_type);
   }
 
+  /**
+   * Compatibility shim for node-fibers: Old-style SetAccessor accepting
+   * AccessorGetterCallback (Local<String> based) instead of
+   * AccessorNameGetterCallback (Local<Name> based).
+   */
+  void SetAccessor(
+      Local<String> name, AccessorGetterCallback getter,
+      AccessorSetterCallback setter = nullptr,
+      Local<Value> data = Local<Value>(), PropertyAttribute attribute = None,
+      SideEffectType getter_side_effect_type = SideEffectType::kHasSideEffect,
+      SideEffectType setter_side_effect_type = SideEffectType::kHasSideEffect) {
+    // String inherits from Name. Safe type pun since Local is just a pointer.
+    Local<Name> name_as_name;
+    static_assert(sizeof(name_as_name) == sizeof(name), "Local size mismatch");
+    memcpy(&name_as_name, &name, sizeof(name));
+    SetNativeDataProperty(
+        name_as_name,
+        reinterpret_cast<AccessorNameGetterCallback>(getter),
+        reinterpret_cast<AccessorNameSetterCallback>(setter), data, attribute,
+        getter_side_effect_type, setter_side_effect_type);
+  }
+
   /**
    * Like SetNativeDataProperty, but V8 will replace the native data property
    * with a real data property on first access.