diff --git a/src/DurableTask.Core/TaskOrchestrationDispatcher.cs b/src/DurableTask.Core/TaskOrchestrationDispatcher.cs index dc97e324e..c85536793 100644 --- a/src/DurableTask.Core/TaskOrchestrationDispatcher.cs +++ b/src/DurableTask.Core/TaskOrchestrationDispatcher.cs @@ -318,7 +318,6 @@ protected async Task OnProcessWorkItemAsync(TaskOrchestrationWorkItem work var timerMessages = new List(); var orchestratorMessages = new List(); var isCompleted = false; - var continuedAsNew = false; var isInterrupted = false; var isRewinding = false; @@ -326,7 +325,6 @@ protected async Task OnProcessWorkItemAsync(TaskOrchestrationWorkItem work CorrelationTraceClient.Propagate(() => CorrelationTraceContext.Current = workItem.TraceContext); ExecutionStartedEvent? continueAsNewExecutionStarted = null; - TaskMessage? continuedAsNewMessage = null; IList? carryOverEvents = null; string? carryOverStatus = null; @@ -389,10 +387,11 @@ protected async Task OnProcessWorkItemAsync(TaskOrchestrationWorkItem work } else { + bool continuedAsNew; do { continuedAsNew = false; - continuedAsNewMessage = null; + TaskMessage? continuedAsNewMessage = null; IReadOnlyList decisions = new List(); bool versioningFailed = false; @@ -707,10 +706,10 @@ protected async Task OnProcessWorkItemAsync(TaskOrchestrationWorkItem work await this.orchestrationService.CompleteTaskOrchestrationWorkItemAsync( workItem, runtimeState, - continuedAsNew ? null : messagesToSend, + messagesToSend, orchestratorMessages, - continuedAsNew ? null : timerMessages, - continuedAsNewMessage, + timerMessages, + continuedAsNewMessage: null, instanceState); if (workItem.RestoreOriginalRuntimeStateDuringCompletion) @@ -718,7 +717,7 @@ await this.orchestrationService.CompleteTaskOrchestrationWorkItemAsync( workItem.OrchestrationRuntimeState = runtimeState; } - return isCompleted || continuedAsNew || isInterrupted || isRewinding; + return isCompleted || isInterrupted || isRewinding; } static OrchestrationExecutionContext GetOrchestrationExecutionContext(OrchestrationRuntimeState runtimeState)