Skip to content

Commit 0b71f3b

Browse files
Fix inconsistent apt usage and duplicate JSC package in Linux build instructions (#1627)
The Linux build instructions listed `libjavascriptcoregtk-4.1-dev` in the base mandatory packages, causing it to be installed for all engine targets (including V8) and duplicating the engine-specific install step. The base command also used `apt` while engine-specific steps used `apt-get`. ## Changes - **Remove `libjavascriptcoregtk-4.1-dev` from base install** — engine-specific packages now live only in their respective engine sections - **Standardize on `apt-get`** throughout the Linux section for consistency Before: ``` sudo apt install libgl1-mesa-dev x11proto-core-dev libx11-dev libcurl4-openssl-dev libjavascriptcoregtk-4.1-dev g++ cmake ninja-build npm ``` After: ``` sudo apt-get install libgl1-mesa-dev x11proto-core-dev libx11-dev libcurl4-openssl-dev g++ cmake ninja-build npm ``` <!-- START COPILOT CODING AGENT TIPS --> --- 🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. [Learn more about Advanced Security.](https://gh.io/cca-advanced-security) --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bkaradzic-microsoft <260535795+bkaradzic-microsoft@users.noreply.github.com>
1 parent c1e3237 commit 0b71f3b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

BUILDING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ The minimal requirement target is an OpenGL 3.3 compatible GPU. Clang 9+ or GCC
279279
First step is to install packages mandatory for building. For example, with a GCC toolchain:
280280

281281
```
282-
sudo apt install libgl1-mesa-dev x11proto-core-dev libx11-dev libcurl4-openssl-dev libjavascriptcoregtk-4.1-dev g++ cmake ninja-build npm
282+
sudo apt-get install libgl1-mesa-dev x11proto-core-dev libx11-dev libcurl4-openssl-dev g++ cmake ninja-build npm
283283
```
284284

285285
Depending on the JavaScript engine you want to use, you will have to install the package accordingly:

0 commit comments

Comments
 (0)