Skip to content

Bug: Type 2 warn2normal restoral path omits acknowledgment check #747

@somethingwithproof

Description

@somethingwithproof

Summary

In thold_functions.php (line ~3452), the type 2 warn-to-normal restoral path is missing the acknowledgment guard that all other send paths include:

// Type 2 warn2normal (missing acknowledgment check):
if (trim($warning_emails) != '' && $thold_data['restored_alert'] != 'on') {
    thold_mail(...);
}

// Type 0 equivalent (correct):
if (trim($warning_emails) != '' && $thold_data['restored_alert'] != 'on'
    && $thold_data['acknowledgment'] == '') {
    thold_mail(...);
}

Acknowledged time-based thresholds still emit warning restoral emails.

Fix

Add && $thold_data['acknowledgment'] == '' to the type 2 warn2normal send guard.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions