Refactor angle type and proper fraction functions; enhance tests for accuracy and coverage

Author: Darkidd77

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -29,7 +29,6 @@ function getAngleType(angle) {
   } else {
     return "Invalid angle";
   }
-
 }
 
 // The line below allows us to load the getAngleType function into tests in other files.
@@ -69,5 +68,3 @@ assertEquals(reflex, "Reflex angle");
 // Example: Identify Invalid Angles
 const invalid = getAngleType(-45);
 assertEquals(invalid, "Invalid angle");
-
-

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -13,12 +13,12 @@
 function isProperFraction(numerator, denominator) {
   // TODO: Implement this function
   if (denominator === 0) {
-    return false; // A fraction with a denominator of 0 is undefined, so it's not a proper fraction.
+    return false;
   }
   if (Math.abs(numerator) < Math.abs(denominator)) {
-    return true; // A proper fraction has an absolute value of the numerator less than the absolute value of the denominator.
+    return true;
   }
-  return false; // If none of the above conditions are met, it's not a proper fraction.
+  return false;
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
@@ -64,4 +64,4 @@ assertEquals(isProperFraction(1, 0), false);
 assertEquals(isProperFraction(-1, 0), false);
 
 // Example: 0/0 is not a proper fraction (undefined)
-assertEquals(isProperFraction(0, 0), false);  
+assertEquals(isProperFraction(0, 0), false);

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -11,6 +11,7 @@ test(`should return "Acute angle" when (0 < angle < 90)`, () => {
   expect(getAngleType(1)).toEqual("Acute angle");
   expect(getAngleType(45)).toEqual("Acute angle");
   expect(getAngleType(89)).toEqual("Acute angle");
+  expect(getAngleType(89.9)).toBe("Acute angle");
 });
 
 // Case 2: Right angle

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -11,16 +11,16 @@ test(`should return false when denominator is zero`, () => {
   expect(isProperFraction(0, 0)).toEqual(false);
 });
 
-test(`should return true for valid proper fractions for negatives`, () => {
+test(`should return true for valid proper fractions for Positives and Negatives`, () => {
   expect(isProperFraction(1, 2)).toEqual(true);
   expect(isProperFraction(-1, 2)).toEqual(true);
   expect(isProperFraction(1, -2)).toEqual(true);
   expect(isProperFraction(-1, -2)).toEqual(true);
 });
 
-test(`should return false when denominator is zero`, () => {
+test(`should return false for improper fraction`, () => {
   expect(isProperFraction(-1, 0)).toEqual(false);
-  expect(isProperFraction(2, 1)).toBe(false);
-  expect(isProperFraction(-2, 1)).toBe(false);
-  expect(isProperFraction(2, 2)).toBe(false);
+  expect(isProperFraction(2, 1)).toEqual(false);
+  expect(isProperFraction(-2, 1)).toEqual(false);
+  expect(isProperFraction(2, 2)).toEqual(false);
 });

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -34,6 +34,8 @@ test(`Should throw an error for invalid cards`, () => {
   expect(() => getCardValue("invalid")).toThrow();
   expect(() => getCardValue("AinvalidSuit")).toThrow();
   expect(() => getCardValue("InvalidRank♠")).toThrow();
+  expect(() => getCardValue("A♤")).toThrow("Invalid card: Invalid suit");
+  expect(() => getCardValue("11♠")).toThrow("Invalid card: Invalid rank");
 });
 
 // Suggestion: Group the remaining test data into these categories: