Skip to content

Commit 82ab4ea

Browse files
committed
Add no learning param
1 parent 84166f3 commit 82ab4ea

File tree

2 files changed

+22
-20
lines changed

2 files changed

+22
-20
lines changed

agents/base2/base-deep-evals.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { createBaseDeep } from './base-deep'
22

33
const definition = {
4-
...createBaseDeep({ noAskUser: true }),
4+
...createBaseDeep({ noAskUser: true, noLearning: true }),
55
id: 'base-deep-evals',
66
displayName: 'Buffy the Codex Evals Orchestrator',
77
}

agents/base2/base-deep.ts

Lines changed: 21 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
type SecretAgentDefinition,
77
} from '../types/secret-agent-definition'
88

9-
function buildDeepSystemPrompt(noAskUser: boolean): string {
9+
function buildDeepSystemPrompt(noAskUser: boolean, noLearning: boolean): string {
1010
return `You are Buffy, a strategic assistant that orchestrates complex coding tasks through specialized sub-agents. You are the AI agent behind the product, Codebuff, a CLI tool where users can chat with you to code with AI.
1111
1212
# Core Mandates
@@ -70,9 +70,9 @@ For other questions, you can direct them to codebuff.com, or especially codebuff
7070
7171
[ Phase 5 — Review Loop: You spawn code-reviewer-codex, fix any issues found, and re-run the reviewer until no new issues are found ]
7272
73-
[ Phase 6 — Validate: You run unit tests, add new tests, fix failures, and attempt E2E verification by running the application ]
73+
[ Phase 6 — Validate: You run unit tests, add new tests, fix failures, and attempt E2E verification by running the application ]${noLearning ? '' : `
7474
75-
[ Phase 7 — Lessons: You write LESSONS.md in the session directory and update/create skill files with key learnings ]
75+
[ Phase 7 — Lessons: You write LESSONS.md in the session directory and update/create skill files with key learnings ]`}
7676
</response>
7777
7878
</example>
@@ -101,10 +101,11 @@ ${PLACEHOLDER.GIT_CHANGES_PROMPT}
101101
`
102102
}
103103

104-
function buildDeepInstructionsPrompt(noAskUser: boolean): string {
104+
function buildDeepInstructionsPrompt(noAskUser: boolean, noLearning: boolean): string {
105+
const totalPhases = noLearning ? 6 : 7
105106
return `Act as a helpful assistant and freely respond to the user's request however would be most helpful to the user. Use your judgement to orchestrate the completion of the user's request using your specialized sub-agents and tools as needed. Take your time and be comprehensive. Don't surprise the user. For example, don't modify files if the user has not asked you to do so at least implicitly.
106107
107-
Follow this 7-phase workflow for implementation tasks. For simple questions or explanations, answer directly without going through all phases.
108+
Follow this ${totalPhases}-phase workflow for implementation tasks. For simple questions or explanations, answer directly without going through all phases.
108109
109110
## Two-Phase Todo Tracking
110111
@@ -119,8 +120,8 @@ These help the user understand what's about to happen before any code is written
119120
**Implementation todos** — Write these AFTER Phase 3 (Plan) is complete, replacing the planning todos:
120121
- One todo per implementation step from the finalized PLAN.md
121122
- Phase 5: Review loop
122-
- Phase 6: Validate changes
123-
- Phase 7: Capture lessons & update skills
123+
- Phase 6: Validate changes${noLearning ? '' : `
124+
- Phase 7: Capture lessons & update skills`}
124125
Update these as you complete each step during implementation.
125126
126127
## Phase 1 — Codebase Context & Research
@@ -174,7 +175,7 @@ Create a detailed implementation plan, iteratively critique it, and save it alon
174175
b. If the thinker raises valid critiques, update PLAN.md to address them.
175176
c. After updating, you MUST spawn thinker-codex again to re-critique the revised plan.
176177
d. Repeat until the thinker finds no new substantive critiques. Do NOT skip the re-critique — every revision must be verified.
177-
3. Write implementation todos (the second phase of todos) — one todo per plan step, plus todos for phases 5-7.
178+
3. Write implementation todos (the second phase of todos) — one todo per plan step, plus todos for phases 5-${noLearning ? '6' : '7'}.
178179
179180
## Phase 4 — Implement
180181
@@ -205,7 +206,7 @@ Thoroughly validate the changes:
205206
- For a CLI tool: run it with relevant arguments
206207
- For a library: write and run a small integration script
207208
- For config/infra changes: validate the configuration is correct
208-
4. If E2E verification reveals issues, fix them and re-validate.
209+
4. If E2E verification reveals issues, fix them and re-validate.${noLearning ? '' : `
209210
210211
## Phase 7 — Lessons
211212
@@ -236,21 +237,22 @@ Capture learnings for future sessions:
236237
a. Spawn thinker-codex to critique your LESSONS.md and skill file edits — ask it to identify missing insights, improvements to existing entries, and brainstorm additional skills that could be created or updated based on the work done in this session.
237238
b. If the thinker suggests valid improvements or new skill ideas, update the relevant files accordingly.
238239
c. After updating, you MUST spawn thinker-codex again to re-critique and brainstorm further.
239-
d. Repeat until the thinker finds no new substantive improvements or skill ideas. Do NOT skip the re-critique — every revision must be verified.${noAskUser ? '' : `
240-
4. Use suggest_followups to suggest ~3 next steps the user might want to take.`}
240+
d. Repeat until the thinker finds no new substantive improvements or skill ideas. Do NOT skip the re-critique — every revision must be verified.`}${noAskUser ? '' : `
241+
${noLearning ? '1' : '4'}. Use suggest_followups to suggest ~3 next steps the user might want to take.`}
241242
242243
Make sure to narrate to the user what you are doing and why you are doing it as you go along. Give a very short summary of what you accomplished at the end of your turn.
243244
244245
## Followup Requests
245246
246-
If the full 7-phase workflow has already been completed in this conversation and the user is asking for a followup change (e.g. "also add X" or "tweak Y"), you do NOT need to repeat the entire workflow. Use your judgement to run only the phases that are relevant — for example, directly make the requested changes (Phase 4), do a light review (Phase 5), and run validation (Phase 6). Skip the spec, and plan phases if the request is a straightforward extension of the work already done. Still update LESSONS.md and skills if you learn anything new.
247+
If the full ${totalPhases}-phase workflow has already been completed in this conversation and the user is asking for a followup change (e.g. "also add X" or "tweak Y"), you do NOT need to repeat the entire workflow. Use your judgement to run only the phases that are relevant — for example, directly make the requested changes (Phase 4), do a light review (Phase 5), and run validation (Phase 6). Skip the spec, and plan phases if the request is a straightforward extension of the work already done.${noLearning ? '' : ' Still update LESSONS.md and skills if you learn anything new.'}
247248
`
248249
}
249250

250251
export function createBaseDeep(options?: {
251252
noAskUser?: boolean
253+
noLearning?: boolean
252254
}): Omit<SecretAgentDefinition, 'id'> {
253-
const { noAskUser = false } = options ?? {}
255+
const { noAskUser = false, noLearning = false } = options ?? {}
254256
return {
255257
publisher,
256258
model: 'openai/gpt-5.3-codex',
@@ -299,20 +301,20 @@ export function createBaseDeep(options?: {
299301
'gpt-5-agent',
300302
'context-pruner',
301303
],
302-
systemPrompt: buildDeepSystemPrompt(noAskUser),
303-
instructionsPrompt: buildDeepInstructionsPrompt(noAskUser),
304-
stepPrompt: `Workflow phases reminder (7 phases):
304+
systemPrompt: buildDeepSystemPrompt(noAskUser, noLearning),
305+
instructionsPrompt: buildDeepInstructionsPrompt(noAskUser, noLearning),
306+
stepPrompt: `Workflow phases reminder (${noLearning ? 6 : 7} phases):
305307
306308
**Planning todos** (write at start): Phase 1 → Phase 2 → Phase 3
307309
1. Context & Research — file-pickers + code-searchers + researchers in parallel, read results
308310
2. Spec — draft SPEC.md, ${noAskUser ? '' : 'iterative ask_user to refine (skip obvious Qs), open-ended final Q, '}thinker-codex critique loop
309311
3. Plan — write PLAN.md, thinker-codex critique loop
310312
311-
**Implementation todos** (write after Plan): one todo per plan step + phases 5-7
313+
**Implementation todos** (write after Plan): one todo per plan step + phases 5-${noLearning ? '6' : '7'}
312314
4. Implement — fully build the spec using file editing tools
313315
5. Review Loop — code-reviewer-codex → fix → re-review until clean
314-
6. Validate — run tests + typechecks, add new tests, do E2E verification
315-
7. Lessons — write LESSONS.md, update/create skills, iterative thinker-codex brainstorm loop`,
316+
6. Validate — run tests + typechecks, add new tests, do E2E verification${noLearning ? '' : `
317+
7. Lessons — write LESSONS.md, update/create skills, iterative thinker-codex brainstorm loop`}`,
316318
handleSteps: function* ({ params }) {
317319
while (true) {
318320
// Run context-pruner before each step.

0 commit comments

Comments
 (0)