pass in logger to linkup api

Author: charleslien

backend/src/__tests__/web-search-tool.test.ts

@@ -143,8 +143,10 @@ describe('web_search tool with researcher agent', () => {
     })
 
     // Just verify that searchWeb was called
-    expect(linkupApi.searchWeb).toHaveBeenCalledWith('test query', {
+    expect(linkupApi.searchWeb).toHaveBeenCalledWith({
+      query: 'test query',
       depth: 'standard',
+      logger: expect.anything(),
     })
   })
 
@@ -190,12 +192,11 @@ describe('web_search tool with researcher agent', () => {
       logger,
     })
 
-    expect(linkupApi.searchWeb).toHaveBeenCalledWith(
-      'Next.js 15 new features',
-      {
-        depth: 'standard',
-      },
-    )
+    expect(linkupApi.searchWeb).toHaveBeenCalledWith({
+      query: 'Next.js 15 new features',
+      depth: 'standard',
+      logger: expect.anything(),
+    })
 
     // Check that the search results were added to the message history
     const toolResultMessages = newAgentState.messageHistory.filter(
@@ -242,19 +243,19 @@ describe('web_search tool with researcher agent', () => {
       fingerprintId: 'test-fingerprint',
       onResponseChunk: () => {},
       agentType: 'researcher',
-      fileContext: mockFileContext,      localAgentTemplates: agentTemplates,
+      fileContext: mockFileContext,
+      localAgentTemplates: agentTemplates,
       agentState,
       prompt: 'Search for React Server Components tutorial with deep search',
       params: undefined,
       logger,
     })
 
-    expect(linkupApi.searchWeb).toHaveBeenCalledWith(
-      'React Server Components tutorial',
-      {
-        depth: 'deep',
-      },
-    )
+    expect(linkupApi.searchWeb).toHaveBeenCalledWith({
+      query: 'React Server Components tutorial',
+      depth: 'deep',
+      logger: expect.anything(),
+    })
   })
 
   test('should handle case when no search results are found', async () => {
@@ -295,12 +296,11 @@ describe('web_search tool with researcher agent', () => {
     })
 
     // Verify that searchWeb was called
-    expect(linkupApi.searchWeb).toHaveBeenCalledWith(
-      'very obscure search query that returns nothing',
-      {
-        depth: 'standard',
-      },
-    )
+    expect(linkupApi.searchWeb).toHaveBeenCalledWith({
+      query: 'very obscure search query that returns nothing',
+      depth: 'standard',
+      logger: expect.anything(),
+    })
 
     // Check that the "no results found" message was added
     const toolResultMessages = newAgentState.messageHistory.filter(
@@ -354,8 +354,10 @@ describe('web_search tool with researcher agent', () => {
     })
 
     // Verify that searchWeb was called
-    expect(linkupApi.searchWeb).toHaveBeenCalledWith('test query', {
+    expect(linkupApi.searchWeb).toHaveBeenCalledWith({
+      query: 'test query',
       depth: 'standard',
+      logger: expect.anything(),
     })
 
     // Check that the error message was added
@@ -409,8 +411,10 @@ describe('web_search tool with researcher agent', () => {
     })
 
     // Verify that searchWeb was called
-    expect(linkupApi.searchWeb).toHaveBeenCalledWith('test query', {
+    expect(linkupApi.searchWeb).toHaveBeenCalledWith({
+      query: 'test query',
       depth: 'standard',
+      logger: expect.anything(),
     })
   })
 
@@ -454,8 +458,10 @@ describe('web_search tool with researcher agent', () => {
     })
 
     // Verify that searchWeb was called
-    expect(linkupApi.searchWeb).toHaveBeenCalledWith('test query', {
+    expect(linkupApi.searchWeb).toHaveBeenCalledWith({
+      query: 'test query',
       depth: 'standard',
+      logger: expect.anything(),
     })
 
     // Check that the error message was added
@@ -511,8 +517,10 @@ describe('web_search tool with researcher agent', () => {
     })
 
     // Verify that searchWeb was called
-    expect(linkupApi.searchWeb).toHaveBeenCalledWith('test formatting', {
+    expect(linkupApi.searchWeb).toHaveBeenCalledWith({
+      query: 'test formatting',
       depth: 'standard',
+      logger: expect.anything(),
     })
 
     // Check that the search results were formatted correctly

backend/src/llm-apis/__tests__/linkup-api.test.ts

@@ -35,10 +35,6 @@ describe('Linkup API', () => {
       },
     }))
 
-    mockModule('@codebuff/backend/util/logger', () => ({
-      logger: mockLogger,
-    }))
-
     // Mock withTimeout utility
     mockModule('@codebuff/common/util/promise', () => ({
       withTimeout: async (promise: Promise<any>, timeout: number) => promise,
@@ -84,7 +80,10 @@ describe('Linkup API', () => {
       }),
     )
 
-    const result = await searchWeb('React tutorial')
+    const result = await searchWeb({
+      query: 'React tutorial',
+      logger: mockLogger,
+    })
 
     expect(result).toBe(
       'React is a JavaScript library for building user interfaces. You can learn how to build your first React application by following the official documentation.',
@@ -128,8 +127,10 @@ describe('Linkup API', () => {
       }),
     )
 
-    const result = await searchWeb('React patterns', {
+    const result = await searchWeb({
+      query: 'React patterns',
       depth: 'deep',
+      logger: mockLogger,
     })
 
     expect(result).toBe(
@@ -157,15 +158,15 @@ describe('Linkup API', () => {
       }),
     )
 
-    const result = await searchWeb('test query')
+    const result = await searchWeb({ query: 'test query', logger: mockLogger })
 
     expect(result).toBeNull()
   })
 
   test('should handle network errors', async () => {
     spyOn(global, 'fetch').mockRejectedValue(new Error('Network error'))
 
-    const result = await searchWeb('test query')
+    const result = await searchWeb({ query: 'test query', logger: mockLogger })
 
     expect(result).toBeNull()
   })
@@ -178,7 +179,7 @@ describe('Linkup API', () => {
       }),
     )
 
-    const result = await searchWeb('test query')
+    const result = await searchWeb({ query: 'test query', logger: mockLogger })
 
     expect(result).toBeNull()
   })
@@ -191,7 +192,7 @@ describe('Linkup API', () => {
       }),
     )
 
-    const result = await searchWeb('test query')
+    const result = await searchWeb({ query: 'test query', logger: mockLogger })
 
     expect(result).toBeNull()
   })
@@ -208,7 +209,7 @@ describe('Linkup API', () => {
       }),
     )
 
-    const result = await searchWeb('test query')
+    const result = await searchWeb({ query: 'test query', logger: mockLogger })
 
     expect(result).toBeNull()
   })
@@ -228,7 +229,7 @@ describe('Linkup API', () => {
       }),
     )
 
-    await searchWeb('test query')
+    await searchWeb({ query: 'test query', logger: mockLogger })
 
     // Verify fetch was called with default parameters
     expect(fetch).toHaveBeenCalledWith(
@@ -251,7 +252,7 @@ describe('Linkup API', () => {
       }),
     )
 
-    const result = await searchWeb('test query')
+    const result = await searchWeb({ query: 'test query', logger: mockLogger })
 
     expect(result).toBeNull()
     // Verify that error logging was called
@@ -269,7 +270,10 @@ describe('Linkup API', () => {
       }),
     )
 
-    const result = await searchWeb('test query for 404')
+    const result = await searchWeb({
+      query: 'test query for 404',
+      logger: mockLogger,
+    })
 
     expect(result).toBeNull()
     // Verify that detailed error logging was called with 404 info

backend/src/llm-apis/linkup-api.ts

@@ -1,7 +1,7 @@
 import { withTimeout } from '@codebuff/common/util/promise'
 import { env } from '@codebuff/internal'
 
-import { logger } from '../util/logger'
+import type { Logger } from '@codebuff/types/logger'
 
 const LINKUP_API_BASE_URL = 'https://api.linkup.so/v1'
 const FETCH_TIMEOUT_MS = 30_000
@@ -23,13 +23,12 @@ export interface LinkupSearchResponse {
  * @param options Search options including depth and max results
  * @returns Array containing a single result with the sourced answer or null if the request fails
  */
-export async function searchWeb(
-  query: string,
-  options: {
-    depth?: 'standard' | 'deep'
-  } = {},
-): Promise<string | null> {
-  const { depth = 'standard' } = options
+export async function searchWeb(options: {
+  query: string
+  depth?: 'standard' | 'deep'
+  logger: Logger
+}): Promise<string | null> {
+  const { query, depth = 'standard', logger } = options
   const apiStartTime = Date.now()
 
   const requestBody = {

backend/src/tools/handlers/tool/web-search.ts

@@ -5,11 +5,11 @@ import { searchWeb } from '../../../llm-apis/linkup-api'
 import { PROFIT_MARGIN } from '../../../llm-apis/message-cost-tracker'
 
 import type { CodebuffToolHandlerFunction } from '../handler-function-type'
-import type { Logger } from '@codebuff/types/logger'
 import type {
   CodebuffToolCall,
   CodebuffToolOutput,
 } from '@codebuff/common/tools/list'
+import type { Logger } from '@codebuff/types/logger'
 
 export const handleWebSearch = ((params: {
   previousToolCallFinished: Promise<void>
@@ -59,7 +59,7 @@ export const handleWebSearch = ((params: {
   const webSearchPromise: Promise<CodebuffToolOutput<'web_search'>> =
     (async () => {
       try {
-        const searchResult = await searchWeb(query, { depth })
+        const searchResult = await searchWeb({ query, depth, logger })
         const searchDuration = Date.now() - searchStartTime
         const resultLength = searchResult?.length || 0
         const hasResults = Boolean(searchResult && searchResult.trim())