Skip to content

Commit d14734d

Browse files
author
Ahmad Awais
committed
🐛 FIX: Eject code removal
1 parent 655d513 commit d14734d

4 files changed

Lines changed: 16 additions & 7 deletions

File tree

packages/cgb-scripts/config/paths.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,5 +32,4 @@ module.exports = {
3232
// These properties only exist before ejecting:
3333
ownPath: resolveOwn( '.' ),
3434
};
35-
36-
console.log( resolveApp( '.' ) );
35+
// @remove-on-eject-end

packages/cgb-scripts/config/webpack.config.dev.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,10 @@ module.exports = {
9393
use: {
9494
loader: 'babel-loader',
9595
options: {
96+
// @remove-on-eject-begin
9697
babelrc: false,
9798
presets: [ require.resolve( 'babel-preset-cgb' ) ],
99+
// @remove-on-eject-end
98100
// This is a feature of `babel-loader` for webpack (not Babel itself).
99101
// It enables caching results in ./node_modules/.cache/babel-loader/
100102
// directory for faster rebuilds.

packages/cgb-scripts/config/webpack.config.prod.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,10 @@ module.exports = {
9393
use: {
9494
loader: 'babel-loader',
9595
options: {
96+
// @remove-on-eject-begin
9697
babelrc: false,
9798
presets: [ require.resolve( 'babel-preset-cgb' ) ],
99+
// @remove-on-eject-end
98100
// This is a feature of `babel-loader` for webpack (not Babel itself).
99101
// It enables caching results in ./node_modules/.cache/babel-loader/
100102
// directory for faster rebuilds.

packages/cgb-scripts/scripts/eject.js

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,15 @@ const chalk = require( 'chalk' );
2929
const paths = require( '../config/paths' );
3030
const inquirer = require( 'inquirer' );
3131
const spawnSync = require( 'cross-spawn' ).sync;
32+
const resolvePkg = require( 'resolve-pkg' );
33+
const cgbDevUtilsPath = resolvePkg( 'cgb-dev-utils', { cwd: __dirname } );
34+
const clearConsole = require( cgbDevUtilsPath + '/clearConsole' );
3235

3336
const green = chalk.green;
3437
const cyan = chalk.cyan;
3538

39+
clearConsole();
40+
3641
function getGitStatus() {
3742
try {
3843
const stdout = execSync( 'git status --porcelain', {
@@ -53,7 +58,7 @@ inquirer
5358
} )
5459
.then( answer => {
5560
if ( ! answer.shouldEject ) {
56-
console.log( cyan( 'Close one! Eject aborted.' ) );
61+
console.log( cyan( '\n\nClose one! Eject aborted.\n\n' ) );
5762
return;
5863
}
5964

@@ -171,11 +176,12 @@ inquirer
171176
delete appPackage.dependencies[ ownPackageName ];
172177
}
173178

174-
// For some reason optionalDependencies end up in dependencies after install.
179+
// Add deps to appPackage.
175180
Object.keys( ownPackage.dependencies ).forEach( key => {
176-
if ( ownPackage.optionalDependencies[ key ] ) {
177-
return;
178-
}
181+
// // For some reason optionalDependencies end up in dependencies after install.
182+
// if ( ownPackage.optionalDependencies[ key ] ) {
183+
// return;
184+
// }
179185
console.log( ` Adding ${ cyan( key ) } to dependencies` );
180186
appPackage.dependencies[ key ] = ownPackage.dependencies[ key ];
181187
} );

0 commit comments

Comments
 (0)