From 46dbe3ce64b67db4584d3fb6320be148117a1dbd Mon Sep 17 00:00:00 2001 From: Reem Ibrahim Date: Tue, 31 Mar 2026 14:50:12 +0100 Subject: [PATCH 1/2] added error handling to urn upload and spec --- app/controllers/admin/urn_lists_controller.rb | 3 ++- spec/features/admin_can_upload_urn_list_spec.rb | 10 ++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/app/controllers/admin/urn_lists_controller.rb b/app/controllers/admin/urn_lists_controller.rb index c67b456e6..bef4706d7 100644 --- a/app/controllers/admin/urn_lists_controller.rb +++ b/app/controllers/admin/urn_lists_controller.rb @@ -18,7 +18,8 @@ def create return redirect_to admin_urn_lists_path end - render action: :new + rescue ActionController::ParameterMissing + redirect_to new_admin_urn_list_path, alert: 'Please choose a file to upload' end def download diff --git a/spec/features/admin_can_upload_urn_list_spec.rb b/spec/features/admin_can_upload_urn_list_spec.rb index 36afd6034..c620374fb 100644 --- a/spec/features/admin_can_upload_urn_list_spec.rb +++ b/spec/features/admin_can_upload_urn_list_spec.rb @@ -24,4 +24,14 @@ expect(UrnListImporterJob).to have_been_enqueued end + + context 'without attaching a file' do + scenario 'displays an error' do + visit new_admin_urn_list_path + + click_button 'Upload' + + expect(page).to have_text 'Please choose a file to upload' + end + end end From 0cc61c0675b5aa69f7dbfaa2d35f0ed45d25c8ee Mon Sep 17 00:00:00 2001 From: Reem Ibrahim Date: Tue, 31 Mar 2026 14:53:21 +0100 Subject: [PATCH 2/2] rubocop --- app/controllers/admin/urn_lists_controller.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/controllers/admin/urn_lists_controller.rb b/app/controllers/admin/urn_lists_controller.rb index bef4706d7..064c03f0a 100644 --- a/app/controllers/admin/urn_lists_controller.rb +++ b/app/controllers/admin/urn_lists_controller.rb @@ -15,9 +15,8 @@ def create if @urn_list.save UrnListImporterJob.perform_later(@urn_list) - return redirect_to admin_urn_lists_path + redirect_to admin_urn_lists_path end - rescue ActionController::ParameterMissing redirect_to new_admin_urn_list_path, alert: 'Please choose a file to upload' end