Merge pull request #5 from Cyber-Syntax/dev

fix: variable.sh notify and add github actions

Author: Cyber-Syntax

.github/workflows/main.yml

@@ -0,0 +1,27 @@
+name: autorelease
+
+on:
+  push:
+    branches: [ master, main ]  # support both master and main branch names
+    tags:
+      - 'v*'  # this will trigger on any tag that starts with 'v'
+
+jobs:
+  release:
+    runs-on: ubuntu-latest
+    
+    steps:
+      - uses: actions/checkout@v3  # updated to newer version
+        with:
+          fetch-depth: 0  # this ensures all tags and history are available
+      
+      - name: create release
+        uses: cupoftea696/gh-action-auto-release@v1.0.2  # updated to newer version
+        with:
+          title: "release: $version"
+          tag: "v$semver"
+          draft: false
+          regex: "/^release: v?#{semver}$/i"  # more flexible regex pattern
+          prereleaseregex: "/^release: v?#{semver}-.*$/i"
+        env:
+          github_token: ${{ secrets.github_token }}

CHANGELOG.md

@@ -0,0 +1,17 @@
+# Changelog
+All notable changes to this project will be documented in this file.
+
+## v0.2.1-alpha
+### Changed
+  - Add github action for release
+  - refactor: variable.sh notify
+  
+## v0.2.0-alpha
+### Changed
+  - fix: specific host options by @Cyber-Syntax in https://github.com/Cyber-Syntax/fedora-setup/pull/3
+  - Add unit tests, improve logging, and enhance backup configurations by @Cyber-Syntax in https://github.com/Cyber-Syntax/fedora-setup/pull/4
+## v0.1.0-alpha
+### What's Changed
+  - Feat/laptop desktop by @Cyber-Syntax in https://github.com/Cyber-Syntax/fedora-setup/pull/1
+  - fix: wrong way to write grub file by @Cyber-Syntax in https://github.com/Cyber-Syntax/fedora-setup/pull/2
+  - Initial setup script for Fedora

setup.sh

@@ -17,19 +17,14 @@ source src/apps.sh
 source src/desktop.sh
 source src/laptop.sh
 
-# Variable notifying the user that the script is running.
-if ! id "$USER" &>/dev/null; then
-  log_warn "You forget to change variables according to your needs. Go src/variables.sh and change according to your needs."
-  # Check if user forgot to change the VARIABLES.
-  if [ -n "$SUDO_USER" ]; then
-    whoami="$SUDO_USER"
-  else
-    whoami=$(whoami)
-  fi
-
-  log_warn "Script USER variable is: $USER but your username: $whoami."
-  log_warn "Please change the USER variable and other variables according to your system configuration."
-
+echo "=================================================="
+echo "important: this script uses configuration values from src/variables.sh"
+echo "please ensure you've reviewed and adjusted these values for your system."
+echo "=================================================="
+#TODO: better way to check and notify user to prevent variable errors.
+read -p "Have you reviewed src/variables.sh? (y/n): " user_confirmed
+if [[ "${user_confirmed,,}" != "y" ]]; then
+  log_warn "Please review src/variables.sh before running this script."
   exit 1
 fi
 
@@ -428,8 +423,6 @@ main() {
     if [[ "$system_type" == "laptop" ]]; then
       log_info "Executing laptop-specific functions..."
       laptop_hostname_change
-      #TEST: Currently on laptop but can be used on globally when desktop switch lightdm
-      nopasswdlogin_group
       tlp_setup
       thinkfan_setup
       touchpad_setup
@@ -450,6 +443,7 @@ main() {
     setup_files "$system_type"
     switch_ufw_setup
 
+    nopasswdlogin_group
     # services
     syncthing_setup
     trash_cli_setup

src/packages.sh

@@ -94,4 +94,5 @@ FLATPAK_PACKAGES=(
   # Proprietary softwares
   md.obsidian.Obsidian
   com.spotify.Client
+  com.zed.Zed # Zed editor
 )

src/variables.sh

@@ -1,8 +1,11 @@
 #!/usr/bin/env bash
 
+
+
+USER=$(whoami)  # automatically detect current user
 # User-specific variables
-# WARN: Change these variables as needed.
-USER="developer"
+# WARN: Change these variables as needed
+# WARNING: Comment out the line below if you want to use the detected user.
 SESSION="qtile"
 LAPTOP_IP="192.168.1.54"