fix: convert Pydantic HttpUrl to string for httpx proxy config#13
Merged
christopherjturner merged 2 commits intoOct 28, 2025
Merged
Conversation
Pydantic v2's HttpUrl is not an httpx.URL and when passed directly to httpx.AsyncHTTPTransport(proxy=...), httpx tries to access .url attribute which doesn't exist in Pydantic v2. This causes runtime error if config.http_proxy is defined. httpx.AsyncHTTPTransport accepts httpx.URL, str, or httpx.Proxy Solution: wrap config.http_proxy with str() before passing to httpx
christopherjturner
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pydantic v2's HttpUrl is not an httpx.URL and when passed directly to httpx.AsyncHTTPTransport(proxy=...), httpx tries to access .url attribute which doesn't exist in Pydantic v2. This causes runtime error if config.http_proxy is defined.
httpx.AsyncHTTPTransport accepts httpx.URL, str, or httpx.Proxy
Solution: wrap config.http_proxy with str() before passing to httpx