address devin review from accessors pr

sid597 · sid597 · commit 36fe06000563 · 2026-02-06T17:52:47.000+05:30
diff --git a/apps/roam/src/components/settings/utils/accessors.ts b/apps/roam/src/components/settings/utils/accessors.ts
@@ -470,18 +470,19 @@ export const setDiscourseNodeSetting = (
   }
 
   let pageUid = nodeType;
-  const blockProps = getBlockPropsByUid(pageUid, []);
+  let blockProps = getBlockPropsByUid(pageUid, []);
 
   if (!blockProps || Object.keys(blockProps).length === 0) {
     const lookedUpUid = getPageUidByPageTitle(
       `${DISCOURSE_NODE_PAGE_PREFIX}${nodeType}`,
     );
     if (lookedUpUid) {
       pageUid = lookedUpUid;
+      blockProps = getBlockPropsByUid(pageUid, []);
     }
   }
 
-  if (!pageUid) {
+  if (!blockProps || Object.keys(blockProps).length === 0) {
     internalError({
       error: `setDiscourseNodeSetting - could not find page for: ${nodeType}`,
       type: "DG Accessor",

Original file line number	Diff line number	Diff line change
`@@ -470,18 +470,19 @@ export const setDiscourseNodeSetting = (`
`470`	`470`	`}`
`471`	`471`
`472`	`472`	`let pageUid = nodeType;`
`473`		`- const blockProps = getBlockPropsByUid(pageUid, []);`
	`473`	`+ let blockProps = getBlockPropsByUid(pageUid, []);`
`474`	`474`
`475`	`475`	`if (!blockProps \|\| Object.keys(blockProps).length === 0) {`
`476`	`476`	`const lookedUpUid = getPageUidByPageTitle(`
`477`	`477`	`${DISCOURSE_NODE_PAGE_PREFIX}${nodeType}`,
`478`	`478`	`);`
`479`	`479`	`if (lookedUpUid) {`
`480`	`480`	`pageUid = lookedUpUid;`
	`481`	`+ blockProps = getBlockPropsByUid(pageUid, []);`
`481`	`482`	`}`
`482`	`483`	`}`
`483`	`484`
`484`		`- if (!pageUid) {`
	`485`	`+ if (!blockProps \|\| Object.keys(blockProps).length === 0) {`
`485`	`486`	`internalError({`
`486`	`487`	error: `setDiscourseNodeSetting - could not find page for: ${nodeType}`,
`487`	`488`	`type: "DG Accessor",`