Skip to content

Commit 4c319d7

Browse files
ndbroadbentclaude
andcommitted
fix test_disabled_for_rake_tasks_in_production - reset server_mode
The test was failing on CI due to other tests setting LogStruct.server_mode = true without resetting it. Since tests can run in any order (random seed), this test would fail when preceded by tests that set server_mode to true. Now explicitly resets server_mode to false before the test and restores it after. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 34510cb commit 4c319d7

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

test/log_struct/configuration_test.rb

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,15 +302,22 @@ def test_enabled_regardless_of_ci_value
302302
end
303303

304304
def test_disabled_for_rake_tasks_in_production
305+
original_server_mode = LogStruct.server_mode?
306+
305307
LogStruct.config.enabled = false
306308
LogStruct.config.enabled_environments = [:production]
307309

308-
# No Rails::Server, no Rails::Console, not test env
310+
# Ensure server_mode is false (might be set by other tests)
311+
LogStruct.server_mode = false
312+
313+
# No Rails::Server, no Rails::Console, not test env - this simulates a rake task
309314
Rails.stub(:env, ActiveSupport::StringInquirer.new("production")) do
310315
LogStruct.set_enabled_from_rails_env!
311316

312317
assert_not LogStruct.config.enabled, "LogStruct should be disabled for rake tasks in production"
313318
end
319+
ensure
320+
LogStruct.server_mode = T.must(original_server_mode)
314321
end
315322

316323
def test_logstruct_enabled_overrides_all_logic

0 commit comments

Comments
 (0)