-
Notifications
You must be signed in to change notification settings - Fork 92
Open
Description
#270 added the viewportSpy option which means that if it is disabled, after onEnter, stopWatching is called.
This makes sense if you're only considering onEnter but if onExit is defined, then it is counterintuitive that it never gets called unless viewportSpy is set to true.
It took me a while to realise why {{in-viewport onEnter=this.onEnter onExit=this.onExit}} only called my onEnter handler.
I would propose a change to the check on
| if (!this.options.viewportSpy) { |
if (!this.options.viewportSpy && !this.args.named.onExit) {
Metadata
Metadata
Assignees
Labels
No labels