Merge pull request #205 from EXP-code/copilot/sub-pr-199

The9Cat · web-flow · commit aeccbd384dd2 · 2026-02-25T14:09:53.000-05:00
Fix thread-unsafe lazy initialization in ExpDeproj::mass()
diff --git a/exputil/ExpDeproj.cc b/exputil/ExpDeproj.cc
@@ -48,11 +48,6 @@ double ExpDeproj::density(double R)
 
 double ExpDeproj::mass(double R)
 {
-  // Initialize precomputed arrays?
-  if (mv.size() == 0) {
-    initialize();
-  }
-
   if (R < 0) {
     throw std::invalid_argument("R must be non-negative");
   }
diff --git a/include/ExpDeproj.H b/include/ExpDeproj.H
@@ -15,7 +15,7 @@ class ExpDeproj
 
 public:
   //! Constructor
-  ExpDeproj(int n=4000) : ngrid(n) {}
+  ExpDeproj(int n=4000) : ngrid(n) { initialize(); }
 
   //! Destructor
   virtual ~ExpDeproj() {}

Original file line number	Diff line number	Diff line change
`@@ -48,11 +48,6 @@ double ExpDeproj::density(double R)`
`48`	`48`
`49`	`49`	`double ExpDeproj::mass(double R)`
`50`	`50`	`{`
`51`		`- // Initialize precomputed arrays?`
`52`		`- if (mv.size() == 0) {`
`53`		`- initialize();`
`54`		`- }`
`55`		`-`
`56`	`51`	`if (R < 0) {`
`57`	`52`	`throw std::invalid_argument("R must be non-negative");`
`58`	`53`	`}`