Type of function to add or improvement
Others
Your ideas
It would be nice if the VaultUnlocked implementation did not fail when passed a not-null world:
|
if (worldName != null) { |
|
return EconomyResponse(amount, getBalance(pluginName, uuid), EconomyResponse.ResponseType.FAILURE, MULTI_WORLD_CURRENCIES_NOT_SUPPORTED_MESSAGE) |
|
} |
I think most economy plugins would just direct things to the non-world method like you do anyways.
I found this to be an issue while updating Towny to use VaultUnlocked and found your economy plugin to be the first (almost) working plugin. I did manage to get things working when I modified Towny to pass a null world, but that isn't something I want to do outside of a test environment.
Type of function to add or improvement
Others
Your ideas
It would be nice if the VaultUnlocked implementation did not fail when passed a not-null world:
LiteEco/src/main/kotlin/com/github/encryptsl/lite/eco/common/hook/vault/unlocked/AdaptiveEconomyVaultUnlockedAPI.kt
Lines 145 to 147 in 9827615
I think most economy plugins would just direct things to the non-world method like you do anyways.
I found this to be an issue while updating Towny to use VaultUnlocked and found your economy plugin to be the first (almost) working plugin. I did manage to get things working when I modified Towny to pass a null world, but that isn't something I want to do outside of a test environment.