[Hold #80151] [$250] Reports shows action, "Pay" but Report Total is incorrect and has a negative total for Reimbursable line items

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.39-3
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @abbagail
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Go to Reports > reports
2. Open Report
3. Scroll down to Report Totals
4. See incorrect line items and mystery negative Reimbursable expense

Expected Result:

For total on report to be correct and all line items to be correct as well

Actual Result:

When you open the report, it shows a different total.
ND shows a negative total for reimbursable items that don't exist

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

The video for the issue is in Slack thread

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @linhvovan29546

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022035412566877483870
• Upwork Job ID: 2035412566877483870
• Last Price Increase: 2026-03-28

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When opening a report, the report total is incorrect. It shows a negative total for "Reimbursable" line items that don't exist, and the "Pay" action is displayed despite the incorrect totals.

What is the root cause of that problem?

There are two contributing issues:

1. nonReimbursableTotal drift due to incorrect reimbursable checks (primary cause)

In multiple places in IOU/index.ts, raw !transaction?.reimbursable is used instead of !getReimbursable(transaction) to decide whether to adjust nonReimbursableTotal. The reimbursable field is optional on the Transaction type (Transaction.ts:564), so when a transaction has reimbursable: undefined, !undefined evaluates to true, incorrectly treating the transaction as non-reimbursable. Meanwhile, getReimbursable() at TransactionUtils/index.ts:1250 correctly defaults to true.

This happens during:

• Transaction edits (IOU/index.ts:4316)
• Transaction deletes (IOU/index.ts:8054)
• Hold operations (IOU/Hold.ts:116)

Over multiple operations, nonReimbursableTotal grows larger in magnitude than total, and since reimbursableSpend is derived by subtraction (totalDisplaySpend - nonReimbursableSpend) in getMoneyRequestSpendBreakdown(), this produces a negative reimbursable amount.

2. Pay button uses !== 0 instead of > 0 for expense reports

At ReportPrimaryActionUtils.ts:205, the condition is reimbursableSpend !== 0, which allows negative values to show the Pay button. IOU reports at line 215 correctly use reimbursableSpend > 0.

What changes do you think we should make in order to solve the problem?

1. Replace raw !transaction?.reimbursable checks with !getReimbursable(transaction) in IOU/index.ts (lines 4316, 4326, 8054, 8056, 8065) and IOU/Hold.ts (line 116, 398). This ensures transactions with reimbursable: undefined are correctly treated as reimbursable (matching the backend default).

2. Change reimbursableSpend !== 0 to reimbursableSpend > 0 at ReportPrimaryActionUtils.ts:205 for expense reports, matching the IOU report check at line 215. This prevents a negative reimbursable amount from triggering the Pay button.

What alternative solutions did you explore? (Optional)

An alternative would be to recompute reimbursableSpend from actual transaction data instead of deriving it by subtracting nonReimbursableSpend from totalDisplaySpend. However, this would be a larger architectural change and the report-level totals are server-authoritative. Fixing the raw checks to use the canonical helper is the minimal targeted fix.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @linhvovan29546 (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022035412566877483870

[chengyixu]

Proposal:

Understanding the issue: When opening a report in New Dot (web), the Report Total displays incorrectly — showing a negative total for Reimbursable line items that don't actually exist. The report also shows a 'Pay' action despite the totals being wrong, which is potentially dangerous for financial integrity.

Root cause analysis: This is likely a calculation bug in the report total aggregation logic. The negative reimbursable total suggests expenses are being double-counted or subtracted instead of added. Common causes:

1. Report totals summing both the original expense and a reversal/adjustment entry incorrectly
2. A sign error in how reimbursable vs non-reimbursable amounts are accumulated in ReportUtils.ts or similar
3. Stale cached data causing a mismatch between displayed line items and the computed total

Solution: I will:

1. Identify the root cause in src/libs/ReportUtils.ts — specifically the getReportTotal or equivalent functions that sum reimbursable line items
2. Find where negative phantom expenses are being introduced (likely in expense report calculation or when deleted/voided expenses are not properly excluded)
3. Fix the summation logic to correctly calculate the net reimbursable total
4. Ensure the Pay action visibility is gated on a correct/positive report total to prevent erroneous payments

Implementation plan:

1. Reproduce the issue by creating a report with mixed reimbursable/non-reimbursable expenses
2. Add debug logging to trace the total calculation and identify where the negative value is introduced
3. Fix the calculation logic — likely removing double-counting of cancelled/voided line items
4. Verify the fix works on Chrome (Windows and Mac) where the issue was reproduced
5. Submit PR with before/after screenshots and regression test

Timeline: Can deliver within 48 hours.

CC @Expensify/triage

[chengyixu]

Proposal:

Problem: When opening a report, the total is shown incorrectly — negative reimbursable amounts appear for transactions that shouldn't be marked as non-reimbursable, and the 'Pay' action is shown despite the corrupted totals.

Root cause: In src/libs/actions/IOU/index.ts, raw !transaction?.reimbursable is used in multiple places (transaction edits ~L4316, deletes ~L8054, and hold operations) instead of !getReimbursable(transaction). Since reimbursable is typed as optional on Transaction.ts:564, when the field is undefined, !undefined evaluates to true, incorrectly treating the transaction as non-reimbursable. Meanwhile getReimbursable() in TransactionUtils/index.ts:1250 correctly defaults to true.

Fix approach:

1. Replace all raw !transaction?.reimbursable / transaction?.reimbursable === false checks in IOU/index.ts with calls to getReimbursable(transaction)
2. Audit the same pattern in any other files that touch nonReimbursableTotal calculations
3. Ensure the 'Pay' action visibility is gated on a valid, positive total — add a guard in the component that renders the Pay button to check reportTotal > 0

Testing: Will test on iOS and Android before submitting PR — specifically: edit a transaction with reimbursable: undefined, delete a transaction, and verify totals recalculate correctly in both cases.

Timeline: 48 hours to deliver.

CC @Expensify/triage

[chengyixu]

Proposing to fix this issue.

Root Cause Analysis:
The negative Reimbursable total in Reports is likely caused by a calculation logic error in the report totals aggregation. This typically happens when:

1. ReportUtils.getReportTotal() or similar aggregator double-counts or sign-inverts reimbursable vs non-reimbursable expense line items
2. The Pay action button logic checks a stale/incorrect total snapshot rather than the live computed total
3. A mismatch between the reportTotal stored in Onyx and the computed value from reportActions

Proposed Fix:

• Audit src/libs/ReportUtils.ts around getMoneyRequestSpendBreakdown and total calculation functions
• Check src/components/ReportActionItem/ for where Pay button visibility condition reads total
• Ensure negative reimbursable amounts (e.g., returns/reversals) are correctly excluded or handled
• Add unit test for edge case: report with mixed reimbursable/non-reimbursable where reimbursable nets negative

Timeline: Can deliver fix + tests within 48 hours.

I have experience with React Native, Onyx state management, and Expensify's codebase structure. Ready to start immediately.