Context
This is a follow-up to the Action Badge feature (expanding GBR/RBR with action badges in the Inbox/LHN). Two issues need to be addressed:
Fix deep link regression
Clicking on the LHN action badge is no longer correctly deep-linking to the report/action that triggered the badge. This was previously working but has regressed.
Expected behavior: Clicking the Inbox LHN should:
- If there is an action badge, deep link to the oldest actionable report (ie, the cause of the action badge)
- Note: Expense threads can have a
Fix action badge when there is a violation to resolve. This doesn't have a corresponding reportActionID, so can't be deep linked to directly. In this case, when clicking Fix on an expense with a violation, just open the report scrolled to the top so the expense is visible.
- Otherwise, if there are unread messages, deep link to the oldest unread message
- Otherwise, link to the bottom of the report
Note: This behavior is a little inconsistent due to a bunch of old historical decisions that predate the "super-wide report modal". Please verify that this behavior works correctly and consistently for all report types, including expense reports, expense threads, single-expense reports, etc.
Reference: Slack thread with details
https://github.com/user-attachments/assets/c114fdea-4267-4413-9877-c8210b537c62
Issue Owner
Current Issue Owner: @aimane-chnaif
Context
This is a follow-up to the Action Badge feature (expanding GBR/RBR with action badges in the Inbox/LHN). Two issues need to be addressed:
Fix deep link regression
Clicking on the LHN action badge is no longer correctly deep-linking to the report/action that triggered the badge. This was previously working but has regressed.
Expected behavior: Clicking the Inbox LHN should:
Fixaction badge when there is a violation to resolve. This doesn't have a correspondingreportActionID, so can't be deep linked to directly. In this case, when clickingFixon an expense with a violation, just open the report scrolled to the top so the expense is visible.Note: This behavior is a little inconsistent due to a bunch of old historical decisions that predate the "super-wide report modal". Please verify that this behavior works correctly and consistently for all report types, including expense reports, expense threads, single-expense reports, etc.
Reference: Slack thread with details
https://github.com/user-attachments/assets/c114fdea-4267-4413-9877-c8210b537c62
Issue Owner
Current Issue Owner: @aimane-chnaif