From 84317b45104957c16436807fe5bd67934d14bd78 Mon Sep 17 00:00:00 2001
From: Ye <denise.ye@ubc.ca>
Date: Wed, 29 Apr 2026 21:00:52 -0700
Subject: [PATCH] update notification

---
 .github/workflows/testsPython.yml | 31 ++++++++++++++++++++++++-------
 1 file changed, 24 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/testsPython.yml b/.github/workflows/testsPython.yml
index 452f71d..9e5ab06 100644
--- a/.github/workflows/testsPython.yml
+++ b/.github/workflows/testsPython.yml
@@ -68,12 +68,29 @@ jobs:
   # on the test results.
   notifications:
     needs: python-unit-tests
+    if: always()
     runs-on: ubuntu-latest
     steps:
-      - name: Notify on test results
-        run: |
-          if [ "${{ needs.python-unit-tests.result }}" == "success" ]; then
-            echo "success notifications go here"
-          else
-            echo "failure notifications go here"
-          fi
+      # 1. Notify on SUCCESS  
+      - name: Slack Notification on Success
+        if: ${{ needs.python-unit-tests.result == 'success' }}
+        uses: rtCamp/action-slack-notify@v2
+        env:
+          SLACK_CHANNEL: general
+          SLACK_COLOR: 'good'
+          SLACK_ICON: https://github.com/rtCamp.png?size=48
+          SLACK_TITLE: 'Test Success'
+          SLACK_MESSAGE: 'Python 3.13 Unit Tests passed successfully! ✅'
+          SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
+
+      # 2. Notify on FAILURE
+      - name: Slack Notification on Failure
+        if: ${{ needs.python-unit-tests.result == 'failure' }}
+        uses: rtCamp/action-slack-notify@v2
+        env:
+          SLACK_CHANNEL: general
+          SLACK_COLOR: 'danger'
+          SLACK_ICON: https://github.com/rtCamp.png?size=48
+          SLACK_TITLE: 'Test Failure'
+          SLACK_MESSAGE: 'Python 3.13 Unit Tests failed. Please check the logs. ❌'
+          SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}