Conversion to C++

[AlgorithMagic]

@NathanLovato Hello! I wanted to start this discussions page, as I am sure there will be questions/comments/issues/etc while I convert to c++. I hope that is alright that I opened this discussion up!

[NathanLovato]

Yes, absolutely!

[AlgorithMagic]

I'm working on the parser engine, as Topiary isn't available for c++ directly. The parser engine and encompassing Topiary functionality may take a few days to get working.

[NathanLovato]

You sure you want to do it all by yourself and ship something finished already? You don't want a hand along the way? I'm generally open to change and contributions, and I'm sure you're experienced and can handle the complexity, im asking more about the direction here as it's easy to spend time on something that'll need to be undone or rewritten later.

For example, if you're thinking about adapting or reproduce topiary's functionality in c++, I wouldn't recommend that. Topiary made sense to bootstrap and prototype a formatter because it was available. Making something like it for one GDScript parser would be more work and way less performance than coding something more traditional rule based parsing.

The queries in the scheme file represent formatting rules that could be easily translated into simple procedural code, and made even simpler by separating inline formatting rules from vertical/multiline ones.

Actually topiary here is also a limiting factor, there are notions of pre and post processing that wouldn't be necessary at all without the topiary library. They're just workarounds for performance issues or limitations of the approach.

[AlgorithMagic]

I don't have a preference one way or another for help, I can open a forked public repo or a draft PR for where I am at now if you or others want to help out. I've already finished converting a good chunk of the rust in src to c++, but theres quite a bit of stuff to redo without topiary.

I'm just outside doing some yardwork and hanging out with the kiddos, but when I'm in I'll make a draft PR with where I'm at and give a better reply than this of what my trajectory is right now, current hurdles, and invariance I'm currently working through.

[AlgorithMagic]

Sorry I meant to add into that reply that I'm basically making a gdscript formatter specific equivalent of topiary without any of the additional functionality Topiary has, I agree it's not worth recreating it entirely. More so I'm thinking the same as you said that a procedural code for it would be best suited.

[NathanLovato]

Likewise, I don't have a preference necessarily. It's just if you'd like a hand/not to carry all the burden of figuring everything out on your own.

[AlgorithMagic]

@NathanLovato I am back to working on the project as of 3 hours from now, I had a work contract come in.

I'm going to do a few hours of work on the formatter conversion then I plan to submit a draft PR so you're able to follow along should the need arise for help or you notice anything I've done you'd like changed.

[NathanLovato]

Thank you for letting me know! And whenever you need me, I'll do my best to help.

[NathanLovato]

@AlgorithMagic May I ask if you're still working on or looking to work on this? No worries if you got a job that's keeping you busy or your plans changes or anything. I'd just like to know because I think at this point I will be looking to consolidate and possibly port to C++ no matter what, as this project is clearly looking to be longer-lived than I initially intended it to be, and a toolchain should really be using the same base technology as the engine to be useful to teams who'd like or need to fork and customize it.

I'm going to take time off soon and I'll have long commutes to visit my mom at the hospital so I'd like to move this project forward a little during that time, hence the question. I don't want to step on your toes.

[AlgorithMagic]

@NathanLovato my apologies I never ended up submitting the PR as I mentioned I've realised.

I am definitely still interested in porting to c++, I took a couple weeks to recoup as my last work contract burned me out something fierce but I'm planning to get back into my hobby projects in the next couple of days. My first project being this port to c++.

My apologies for not updating you sooner!

I'll start by finishing up a couple small areas I was working on and then will submit the PR draft so that you or others can assist in the conversion as well. I don't mind doing it alone but more eyes and brains on a task are always a positive.

You can expect the PR draft within 48 hours at most! Thanks for following up and reminding me of this.

[NathanLovato]

No worries, I understand. Don't hesitate also to rest and upload what you have even if unfinished (if you'd like to, at least). You could even leave some quick notes on the things you'd like to achieve or anything that is important to you. I say that mostly so you don't pressure yourself to build and deliver something big all alone!