diff --git a/.changesets/fix_linear_sensor.md b/.changesets/fix_linear_sensor.md new file mode 100644 index 000000000..43916e524 --- /dev/null +++ b/.changesets/fix_linear_sensor.md @@ -0,0 +1,2 @@ +release: patch +summary: Is just one parenthesis come on diff --git a/Inc/ST-LIB_LOW/Sensors/LinearSensor/LinearSensor.hpp b/Inc/ST-LIB_LOW/Sensors/LinearSensor/LinearSensor.hpp index 3d71e7b8f..fd8412158 100644 --- a/Inc/ST-LIB_LOW/Sensors/LinearSensor/LinearSensor.hpp +++ b/Inc/ST-LIB_LOW/Sensors/LinearSensor/LinearSensor.hpp @@ -86,7 +86,7 @@ template requires std::is_integral_v || std::is_floating_point_v Type LinearSensor::compute_value_from_voltage(float voltage) const { const Type sensor_voltage = static_cast(voltage); - return slope * sensor_voltage + offset; + return slope * (sensor_voltage + offset); } template diff --git a/Tests/adc_sensor_test.cpp b/Tests/adc_sensor_test.cpp index 907bb246b..4cd1064ee 100644 --- a/Tests/adc_sensor_test.cpp +++ b/Tests/adc_sensor_test.cpp @@ -125,7 +125,7 @@ TEST_F(ADCSensorTest, LinearSensorUsesNormalizedADCVoltageForItsTransferFunction LinearSensor sensor(SingleADCInit::instances[0], 2.0f, -1.0f, output, 5.0f); sensor.read(); - EXPECT_NEAR(output, 2.0f * ((512.0f / 1023.0f) * 5.0f) - 1.0f, 0.001f); + EXPECT_NEAR(output, 2.0f * (((512.0f / 1023.0f) * 5.0f) - 1.0f), 0.001f); } TEST_F(ADCSensorTest, FilteredLinearSensorReusesTheSameADCConversionPath) { @@ -151,7 +151,7 @@ TEST_F(ADCSensorTest, FilteredLinearSensorReusesTheSameADCConversionPath) { sensor.read(); sensor.read(); - EXPECT_NEAR(output, 2.0f * ((2048.0f / 4095.0f) * 3.3f) + 1.0f, 0.001f); + EXPECT_NEAR(output, 2.0f * (((2048.0f / 4095.0f) * 3.3f) + 1.0f), 0.001f); } TEST_F(ADCSensorTest, LookupSensorMapsEquivalentNormalizedReadingsAcrossResolutions) {