From 360870e28a80ceda3a1593cbd09db11818e8b4ab Mon Sep 17 00:00:00 2001 From: oganigl Date: Fri, 12 Jun 2026 09:29:33 +0200 Subject: [PATCH 1/4] one parenthesis, 2 hours of my time --- Inc/ST-LIB_LOW/Sensors/LinearSensor/LinearSensor.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Inc/ST-LIB_LOW/Sensors/LinearSensor/LinearSensor.hpp b/Inc/ST-LIB_LOW/Sensors/LinearSensor/LinearSensor.hpp index 3d71e7b8f..fd8412158 100644 --- a/Inc/ST-LIB_LOW/Sensors/LinearSensor/LinearSensor.hpp +++ b/Inc/ST-LIB_LOW/Sensors/LinearSensor/LinearSensor.hpp @@ -86,7 +86,7 @@ template requires std::is_integral_v || std::is_floating_point_v Type LinearSensor::compute_value_from_voltage(float voltage) const { const Type sensor_voltage = static_cast(voltage); - return slope * sensor_voltage + offset; + return slope * (sensor_voltage + offset); } template From ba85d251d7b01e29bf94074be6f24ca3743b3d51 Mon Sep 17 00:00:00 2001 From: oganigl Date: Fri, 12 Jun 2026 09:36:45 +0200 Subject: [PATCH 2/4] come on --- .changesets/fix_linear_sensor.md | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 .changesets/fix_linear_sensor.md diff --git a/.changesets/fix_linear_sensor.md b/.changesets/fix_linear_sensor.md new file mode 100644 index 000000000..f9d45f725 --- /dev/null +++ b/.changesets/fix_linear_sensor.md @@ -0,0 +1,2 @@ +release: patch +summary: Is just one parenthesis come on \ No newline at end of file From c1cabecedfbd4a25ac035574bcf72e28723af9a3 Mon Sep 17 00:00:00 2001 From: oganigl Date: Fri, 12 Jun 2026 09:40:37 +0200 Subject: [PATCH 3/4] added one empty line, useful indentation thank you pre-commit --- .changesets/fix_linear_sensor.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changesets/fix_linear_sensor.md b/.changesets/fix_linear_sensor.md index f9d45f725..43916e524 100644 --- a/.changesets/fix_linear_sensor.md +++ b/.changesets/fix_linear_sensor.md @@ -1,2 +1,2 @@ release: patch -summary: Is just one parenthesis come on \ No newline at end of file +summary: Is just one parenthesis come on From 058e5eba389d954cb8359a850fd027972de077d6 Mon Sep 17 00:00:00 2001 From: oganigl Date: Fri, 12 Jun 2026 09:57:19 +0200 Subject: [PATCH 4/4] change test --- Tests/adc_sensor_test.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Tests/adc_sensor_test.cpp b/Tests/adc_sensor_test.cpp index 907bb246b..4cd1064ee 100644 --- a/Tests/adc_sensor_test.cpp +++ b/Tests/adc_sensor_test.cpp @@ -125,7 +125,7 @@ TEST_F(ADCSensorTest, LinearSensorUsesNormalizedADCVoltageForItsTransferFunction LinearSensor sensor(SingleADCInit::instances[0], 2.0f, -1.0f, output, 5.0f); sensor.read(); - EXPECT_NEAR(output, 2.0f * ((512.0f / 1023.0f) * 5.0f) - 1.0f, 0.001f); + EXPECT_NEAR(output, 2.0f * (((512.0f / 1023.0f) * 5.0f) - 1.0f), 0.001f); } TEST_F(ADCSensorTest, FilteredLinearSensorReusesTheSameADCConversionPath) { @@ -151,7 +151,7 @@ TEST_F(ADCSensorTest, FilteredLinearSensorReusesTheSameADCConversionPath) { sensor.read(); sensor.read(); - EXPECT_NEAR(output, 2.0f * ((2048.0f / 4095.0f) * 3.3f) + 1.0f, 0.001f); + EXPECT_NEAR(output, 2.0f * (((2048.0f / 4095.0f) * 3.3f) + 1.0f), 0.001f); } TEST_F(ADCSensorTest, LookupSensorMapsEquivalentNormalizedReadingsAcrossResolutions) {