Skip to content

Commit 3ef2232

Browse files
hjmjohnsonclaude
andcommitted
Remove manylinux2014 support for ITK 6
manylinux2014 is not needed for ITK 6. Remove the manylinux2014 image tag resolution, the manylinux1/manylinux2014 pixi-to-pattern renaming entries, and update shell script comments to reference _2_28 and _2_34 as the supported manylinux versions. Addresses review feedback from @thewtex on PR #302. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 86b1e2f commit 3ef2232

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

scripts/dockcross-manylinux-build-module-wheels.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ if [[ "${TARGET_ARCH}" == "aarch64" ]]; then
7979
IMAGE_TAG=${IMAGE_TAG:-2025.08.12-1}
8080
CONTAINER_SOURCE=${CONTAINER_SOURCE:-"quay.io/pypa/manylinux${MANYLINUX_VERSION}_${TARGET_ARCH}:${IMAGE_TAG}"}
8181
else
82-
# if x64 arch then supported manylinux versions are _2_28 and 2014
82+
# if x64 arch then supported manylinux versions are _2_28 and _2_34
8383
IMAGE_TAG=${IMAGE_TAG:=20260203-3dfb3ff}
8484
CONTAINER_SOURCE=${CONTAINER_SOURCE:-"docker.io/dockcross/manylinux${MANYLINUX_VERSION}-${TARGET_ARCH}:${IMAGE_TAG}"}
8585
fi

scripts/dockcross-manylinux-build-wheels.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ if [[ "${TARGET_ARCH}" == "aarch64" ]]; then
4141
IMAGE_TAG=${IMAGE_TAG:=2025.08.12-1}
4242
CONTAINER_SOURCE=${CONTAINER_SOURCE:="quay.io/pypa/manylinux${MANYLINUX_VERSION}_${TARGET_ARCH}:${IMAGE_TAG}"}
4343
else
44-
# if x64 arch then supported manylinux versions are _2_28 and 2014
44+
# if x64 arch then supported manylinux versions are _2_28 and _2_34
4545
IMAGE_TAG=${IMAGE_TAG:=20260203-3dfb3ff}
4646
CONTAINER_SOURCE=${CONTAINER_SOURCE:="docker.io/dockcross/manylinux${MANYLINUX_VERSION}-${TARGET_ARCH}:${IMAGE_TAG}"}
4747
fi

scripts/wheel_builder_utils.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -582,7 +582,7 @@ def default_manylinux(
582582
Parameters
583583
----------
584584
manylinux_version : str
585-
Manylinux specification (e.g. ``'_2_28'``, ``'2014'``).
585+
Manylinux specification (e.g. ``'_2_28'``, ``'_2_34'``).
586586
os_name : str
587587
Operating system name (only ``'linux'`` triggers resolution).
588588
arch : str
@@ -612,8 +612,6 @@ def default_manylinux(
612612
image_tag = image_tag or "20250913-6ea98ba"
613613
elif arch == "aarch64" and manylinux_version == "_2_28":
614614
image_tag = image_tag or "2025.08.12-1"
615-
elif manylinux_version == "2014":
616-
image_tag = image_tag or "20240304-9e57d2b"
617615
elif manylinux_version == "":
618616
image_tag = ""
619617
else:
@@ -735,8 +733,6 @@ def get_default_platform_build(default_python_version: str = "py311") -> str:
735733
from_pixi = os.environ.get("PIXI_ENVIRONMENT_NAME", None)
736734
if from_pixi and "-" in from_pixi:
737735
manylinux_pixi_to_pattern_renaming: dict[str, str] = {
738-
"manylinux1": "manylinux1",
739-
"manylinux2014": "manylinux2014",
740736
"manylinux228": "manylinux_2_28",
741737
"manylinux234": "manylinux_2_34",
742738
}

0 commit comments

Comments
 (0)