NoMethodError: private method `warn' called for class ActiveSupport::Deprecation

[jagthedrummer]

This issue is a (choose one):

• Problem/bug report.
• Feature request.
• Request for support. Note: Please try to avoid submitting issues for support requests. Use Gitter instead.

Checklist before submitting:

• I've searched for an existing issue.
• I've asked my question on Gitter and have not received a satisfactory answer.
• I've included a complete bug report template. This step helps us and allows us to see the bug without trying to reproduce the problem from your description. It helps you because you will frequently detect if it's a problem specific to your project.
• The feature I'm asking for is compliant with the JSON:API spec.

Description

I'm trying to upgrade to Rails 7.2 and when I run rails app:update the process failed with this error:

$ rails app:update
...
       rails  active_storage:update
bin/rails aborted!
NoMethodError: private method `warn' called for class ActiveSupport::Deprecation (NoMethodError)

        ActiveSupport::Deprecation.warn "In #{name} you exposed a `has_one` relationship "\
                                  ^^^^^
/Users/jgreen/projects/seshy-api/app/resources/jsonapi/v1/user_resource.rb:9:in `<class:UserResource>'
/Users/jgreen/projects/seshy-api/app/resources/jsonapi/v1/user_resource.rb:1:in `<main>'
/Users/jgreen/projects/seshy-api/config/routes.rb:24:in `block (3 levels) in <main>'
/Users/jgreen/projects/seshy-api/config/routes.rb:10:in `block (2 levels) in <main>'
/Users/jgreen/projects/seshy-api/config/routes.rb:9:in `block in <main>'
/Users/jgreen/projects/seshy-api/config/routes.rb:1:in `<main>'
/Users/jgreen/projects/seshy-api/config/environment.rb:5:in `<main>'
Tasks: TOP => active_storage:update => environment
(See full trace by running task with --trace)

[jagthedrummer]

The trouble is that in Rails 7.2 calling methods directly on ActiveSupport::Deprecation has been removed. Now you're supposed to instantiate that class and call the methods on the instances. Something like:

deprecation = ActiveSupport::Deprecation.new("0.10.0", "JSONAPI Resource")
deprecation.warn("In #{name} you exposed a `has_one` relationship")

[takaokouji]

We've fixed this issue in our fork (speee/jsonapi-resources).

Solution: Updated the JSONAPI.warn_deprecated helper to use try/rescue:

• Try calling ActiveSupport::Deprecation.warn as class method (Rails < 7.2)
• On NoMethodError, create Deprecation instance and call warn on it (Rails 7.2+)
• Fallback to Kernel#warn for non-Rails environments

Fix: speee#19

This ensures backward compatibility while supporting Rails 7.2+. Hope this helps!