fix member caching issues with getOwner()

Author: danthe1st

src/main/java/net/discordjug/javabot/listener/JobChannelCloseOldPostsListener.java

@@ -9,6 +9,7 @@
 import net.discordjug.javabot.data.config.guild.ModerationConfig;
 import net.discordjug.javabot.util.InteractionUtils;
 import net.dv8tion.jda.api.EmbedBuilder;
+import net.dv8tion.jda.api.entities.UserSnowflake;
 import net.dv8tion.jda.api.entities.channel.ChannelType;
 import net.dv8tion.jda.api.entities.channel.concrete.ThreadChannel;
 import net.dv8tion.jda.api.events.channel.ChannelCreateEvent;
@@ -53,7 +54,7 @@ public void onChannelCreate(ChannelCreateEvent event) {
 						.setTitle("Post closed")
 						.setDescription("This post has been blocked because you have created other recent posts.\nPlease do not spam posts.")
 						.build())
-				.setContent(post.getOwner().getAsMention())
+				.setContent(UserSnowflake.fromId(post.getOwnerIdLong()).getAsMention())
 				.flatMap(msg -> post.getManager().setArchived(true).setLocked(true))
 				.queue();
 				return;

src/main/java/net/discordjug/javabot/systems/help/HelpForumUpdater.java

@@ -81,9 +81,8 @@ private void checkForumPost(@NotNull ThreadChannel post, HelpConfig config) {
 	private void sendDMDormantInfoIfEnabled(ThreadChannel post, HelpConfig config) {
 		if(Boolean.parseBoolean(preferenceService.getOrCreate(post.getOwnerIdLong(), Preference.PRIVATE_DORMANT_NOTIFICATIONS).getState())) {
 			post
-				.getOwner()
-				.getUser()
-				.openPrivateChannel()
+				.getJDA()
+				.openPrivateChannelById(post.getOwnerIdLong())
 				.flatMap(c -> c.sendMessageEmbeds(createDMDormantInfo(post, config)))
 				.queue();
 		}

src/main/java/net/discordjug/javabot/systems/help/HelpManager.java

@@ -117,10 +117,11 @@ public void close(IReplyCallback callback, boolean withHelpers, @Nullable String
 				.queue(s -> postThread.getManager().setLocked(true).setArchived(true).queue());
 		if (callback.getMember().getIdLong() != postThread.getOwnerIdLong() &&
 				Boolean.parseBoolean(preferenceService.getOrCreate(postThread.getOwnerIdLong(), Preference.PRIVATE_CLOSE_NOTIFICATIONS).getState())) {
-
-			postThread.getOwner().getUser().openPrivateChannel()
-					.flatMap(c -> createDMCloseInfoEmbed(callback.getMember(), postThread, reason, c))
-					.queue(success -> {}, failure -> {});
+			postThread
+				.getJDA()
+				.openPrivateChannelById(postThread.getOwnerIdLong())
+				.flatMap(c -> createDMCloseInfoEmbed(callback.getMember(), postThread, reason, c))
+				.queue(success -> {}, failure -> {});
 
 			botConfig.get(callback.getGuild())
 				.getModerationConfig()
@@ -191,13 +192,15 @@ public void thankHelper(@NotNull Guild guild, ThreadChannel postThread, long hel
 				service.performTransaction(helper.getIdLong(), config.getThankedExperience(), guild, postThread.getIdLong());
 			} catch (SQLException e) {
 				ExceptionLogger.capture(e, getClass().getSimpleName());
-				botConfig.get(guild).getModerationConfig().getLogChannel().sendMessageFormat(
-						"Could not record user %s thanking %s for help in post %s: %s",
-						UserUtils.getUserTag(postThread.getOwner().getUser()),
-						UserUtils.getUserTag(helper),
-						postThread.getAsMention(),
-						e.getMessage()
-				).queue();
+				guild.getJDA().retrieveUserById(postThread.getOwnerIdLong()).queue(owner -> {
+					botConfig.get(guild).getModerationConfig().getLogChannel().sendMessageFormat(
+							"Could not record user %s thanking %s for help in post %s: %s",
+							UserUtils.getUserTag(owner),
+							UserUtils.getUserTag(helper),
+							postThread.getAsMention(),
+							e.getMessage()
+							).queue();
+				});
 			}
 		});
 	}

src/main/java/net/discordjug/javabot/util/WebhookUtil.java

@@ -65,8 +65,8 @@ public static void ensureWebhookExists(@NotNull IWebhookContainer channel, @NotN
 		channel.retrieveWebhooks().queue(webhooks -> {
 			Optional<Webhook> hook = webhooks.stream()
 					.filter(webhook -> webhook.getChannel().getIdLong() == channel.getIdLong())
-					.filter(wh -> wh.getOwner() != null)
-					.filter(wh -> wh.getOwner().getIdLong() == channel.getJDA().getSelfUser().getIdLong())
+					.filter(wh -> wh.getOwnerAsUser() != null)
+					.filter(wh -> wh.getOwnerAsUser().getIdLong() == channel.getJDA().getSelfUser().getIdLong())
 					.filter(wh -> wh.getToken() != null)
 					.findAny();
 			if (hook.isPresent()) {