From 6c3e189e7776f9e838614fa6a6cf3b1149006b8a Mon Sep 17 00:00:00 2001 From: JamesWrigley Date: Sat, 2 Aug 2025 18:10:19 +0200 Subject: [PATCH 1/2] Fix interface selection when some interfaces don't report a speed --- docs/src/_changelog.md | 3 +++ src/cluster.jl | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/docs/src/_changelog.md b/docs/src/_changelog.md index 98ba96a..8bac450 100644 --- a/docs/src/_changelog.md +++ b/docs/src/_changelog.md @@ -19,6 +19,9 @@ This documents notable changes in DistributedNext.jl. The format is based on port is specified. Previously this would cause errors when the workers all tried to bind to the same port, now all additional workers will treat the bind port as a port hint ([#19]). +- Fixed a bug in the network interface selection code that would cause it to + error when only a subset of interfaces reported the negotiation speed + ([#29]). ### Added - A watcher mechanism has been added to detect when both the Distributed stdlib diff --git a/src/cluster.jl b/src/cluster.jl index 3ca82d9..2c8f2f7 100644 --- a/src/cluster.jl +++ b/src/cluster.jl @@ -1374,8 +1374,8 @@ function init_bind_addr() # If none of them report speed just pick the first one bind_addr = string(interfaces[1].ip) else - idx = findmax(x -> x.speed, interfaces)[2] - bind_addr = string(interfaces[idx].ip) + idx = findmax(x -> x.speed, interfaces_with_speed)[2] + bind_addr = string(interfaces_with_speed[idx].ip) end end end From bc421f5b9d5ee1e6177911d01a1228f0c5a505ef Mon Sep 17 00:00:00 2001 From: JamesWrigley Date: Sat, 2 Aug 2025 18:11:43 +0200 Subject: [PATCH 2/2] Bump version --- Project.toml | 2 +- docs/src/_changelog.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Project.toml b/Project.toml index 26447ea..9afe483 100644 --- a/Project.toml +++ b/Project.toml @@ -1,6 +1,6 @@ name = "DistributedNext" uuid = "fab6aee4-877b-4bac-a744-3eca44acbb6f" -version = "1.0.0" +version = "1.1.0" [deps] Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c" diff --git a/docs/src/_changelog.md b/docs/src/_changelog.md index 8bac450..9eec614 100644 --- a/docs/src/_changelog.md +++ b/docs/src/_changelog.md @@ -7,7 +7,7 @@ CurrentModule = DistributedNext This documents notable changes in DistributedNext.jl. The format is based on [Keep a Changelog](https://keepachangelog.com). -## Unreleased +## [v1.1.0] - 2025-08-02 ### Fixed - Fixed a cause of potential hangs when exiting the process ([#16]).