-
Notifications
You must be signed in to change notification settings - Fork 78
MSAA page documentation is inconsistent with the code: it is outdated. #341
Description
The section in the MSAA tutorial: https://docs.vulkan.org/tutorial/latest/10_Multisampling.html#_adding_new_attachments
It is inconsitent with the code, as those code fragments don't exist or don't match with the explanation, e.g.:
void createRenderPass() {
// ....
depthAttachment.samples = msaaSamples;
// ...
}that function doesn't exist at all and in the code the section related to the .renderPass is set to nulptr.
as well there is no variable .samples to set and looking at the code there is nowhere where is used.
This mislead the tutorial, make it very difficult to understand and to follow as from that point is like for an older version of vulkans, actually for the older tutorial without dynamic_rendering.
Would it be possible to update with the dynamic_rendering and eventually these old information move into an appendix paragraph to explain in such case "if we weren't using dynamic rendering we should have done/create/whatever ...." ?