Skip to content

Commit 59fdc4e

Browse files
authored
Merge pull request #30 from KingPin/dockerfile-retry-improvements
refactor: Dockerfile cleanup, retry improvements, and CI fixes
2 parents 78a96b9 + 455e3a2 commit 59fdc4e

10 files changed

Lines changed: 218 additions & 693 deletions

File tree

.github/docker-setup/action.yml

Lines changed: 0 additions & 18 deletions
This file was deleted.

.github/workflows/docker-ci.yml

Lines changed: 25 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,22 +32,19 @@ concurrency:
3232
jobs:
3333
build-and-test:
3434
runs-on: ubuntu-latest
35-
# runs-on: arc-s2-runner
3635
strategy:
3736
fail-fast: false
3837
matrix:
3938
variant: [v1, v2]
4039
php-version: ['8.4', '8.3', '8.2']
41-
php-type: [fpm, cli]
40+
php-type: [fpm, cli, apache]
4241
php-base: [alpine, bookworm]
4342
exclude:
4443
- php-type: apache
4544
php-base: alpine
46-
# v2 uses trixie as the Debian base; bookworm retained for v1
4745
- variant: v2
4846
php-base: bookworm
4947
include:
50-
# v2 builds on trixie for Debian images
5148
- variant: v2
5249
php-version: '8.4'
5350
php-type: fpm
@@ -56,6 +53,10 @@ jobs:
5653
php-version: '8.4'
5754
php-type: cli
5855
php-base: trixie
56+
- variant: v2
57+
php-version: '8.4'
58+
php-type: apache
59+
php-base: trixie
5960
- variant: v2
6061
php-version: '8.3'
6162
php-type: fpm
@@ -64,6 +65,10 @@ jobs:
6465
php-version: '8.3'
6566
php-type: cli
6667
php-base: trixie
68+
- variant: v2
69+
php-version: '8.3'
70+
php-type: apache
71+
php-base: trixie
6772
- variant: v2
6873
php-version: '8.2'
6974
php-type: fpm
@@ -72,6 +77,10 @@ jobs:
7277
php-version: '8.2'
7378
php-type: cli
7479
php-base: trixie
80+
- variant: v2
81+
php-version: '8.2'
82+
php-type: apache
83+
php-base: trixie
7584

7685
name: ${{ matrix.variant }}-${{ matrix.php-version }}-${{ matrix.php-type }}-${{ matrix.php-base }}
7786

@@ -269,6 +278,18 @@ jobs:
269278
echo "✅ PHP-FPM version check passed"
270279
echo "::endgroup::"
271280
281+
- name: Smoke tests - Apache specific
282+
if: matrix.php-type == 'apache'
283+
run: |
284+
echo "::group::Testing Apache"
285+
if ! docker run --rm test-${{ steps.vars.outputs.TAG }} apache2 -v 2>&1 | tee apache-version.txt; then
286+
echo "::error::Failed to run apache2 -v"
287+
cat apache-version.txt || true
288+
exit 1
289+
fi
290+
echo "✅ Apache version check passed"
291+
echo "::endgroup::"
292+
272293
- name: Summary
273294
run: |
274295
echo "::notice::✅ Build and tests passed for ${{ matrix.variant }} - ${{ steps.vars.outputs.TAG }}"
@@ -277,7 +298,6 @@ jobs:
277298
needs: build-and-test
278299
if: github.ref == 'refs/heads/main' && (github.event_name == 'push' || github.event_name == 'schedule')
279300
runs-on: ubuntu-latest
280-
# runs-on: arc-s2-runner
281301
strategy:
282302
fail-fast: false
283303
matrix:

.github/workflows/docker-image.v1.yml

Lines changed: 0 additions & 112 deletions
This file was deleted.

0 commit comments

Comments
 (0)