Fixing permission problem: adding new users to users group. Added test case for empty last name. All tests pass.

Author: Paul Philion

data/empty-name.eml

@@ -0,0 +1,15 @@
+MIME-Version: 1.0
+Date: Wed, 1 Nov 2023 14:28:46 -0700
+References: <CANgxLuvVTiJi3BGF4vN+MXN154pVJ7kYvwDOTJuTC_KYfe0teA@mail.gmail.com>
+In-Reply-To: <CANgxLuvVTiJi3BGF4vN+MXN154pVJ7kYvwDOTJuTC_KYfe0teA@mail.gmail.com>
+Message-ID: <CANgxLutVdUkfeyOPSkO8uuDhUWm+R+twkDn=BSYx-T8GQnk9sA@mail.gmail.com>
+Subject: Fwd: Another test ticket
+From: Yoyodyne <info@example.com>
+To: Babo <babo@example.org>
+Content-Type: multipart/alternative; boundary="000000000000d5d3b506091df47e"
+
+--000000000000d5d3b506091df47e
+Content-Type: text/plain; charset="UTF-8"
+Content-Transfer-Encoding: quoted-printable
+
+another test

redmine/users.py

@@ -220,7 +220,7 @@ def create(self, email:str, first:str, last:str, user_login:str|None) -> User:
         # check status
         if r:
             user = User(**r['user'])
-
+            self.cache.cache_user(user)
             log.info(f"created user: {user.id} {user.login} {user.mail}")
 
             return user

tests/test_imap.py

@@ -85,7 +85,7 @@ def test_email_address_parsing2(self):
         addr = 'philion <philion@gmail.com>'
         first, last, email = self.imap.parse_email_address(addr)
         self.assertEqual("philion", first)
-        self.assertEqual("", last)
+        self.assertEqual("-", last)
         self.assertEqual("philion@gmail.com", email)
 
         addr2 = 'Paul Philion <philion@acmerocket.com>'
@@ -325,3 +325,22 @@ def test_add_note(self):
         last_note = ticket.get_notes()[-1]
         self.assertEqual(last_note.user.id, user.id)
         self.assertEqual(last_note.notes, note)
+
+
+    def test_empty_name(self):
+        try:
+            test_email = None
+            user = None
+            with open("data/empty-name.eml", 'rb') as file:
+                message = self.imap.parse_message(file.read())
+                log.debug(f"loaded message: {message}")
+                self.imap.handle_message("test", message)
+                _, _, test_email = self.imap.parse_email_address(message.from_address)
+
+            user = self.redmine.user_mgr.find(test_email)
+            self.assertIsNotNone(user, f"Couldn't find user for {test_email}")
+            self.assertEqual(test_email, user.mail)
+        finally:
+            if user:
+                # remove the user after the test
+                self.redmine.user_mgr.remove(user)

threader/imap.py

@@ -63,7 +63,7 @@ def parse_email_address(self, email_addr):
                 first, last = name.rsplit(None, 1)
             else:
                 first = name
-                last = ""
+                last = "-" # empty string breaks redmine
             addr = m.group(2)
 
             return first, last, addr
@@ -202,6 +202,8 @@ def handle_message(self, msg_id:str, message:Message):
             # create new user
             user = self.redmine.user_mgr.create(addr, first, last, user_login=None)
             log.info(f"Unknow user: {addr}, created new account.")
+        # make sure user is in users group
+        self.redmine.user_mgr.join_team(user, "users")
 
         #  upload any attachments
         self.redmine.ticket_mgr.upload_attachments(user, message.attachments)