fix: decouple surfaces from model if model has been reset.

Author: lachlangrose

loopstructural/gui/visualisation/feature_list_widget.py

@@ -2,9 +2,8 @@
 from typing import Optional, Union
 
 import numpy as np
-from PyQt5.QtWidgets import QMenu, QPushButton, QTreeWidget, QTreeWidgetItem, QVBoxLayout, QWidget
-
 from LoopStructural.datatypes import VectorPoints
+from PyQt5.QtWidgets import QMenu, QPushButton, QTreeWidget, QTreeWidgetItem, QVBoxLayout, QWidget
 
 logger = logging.getLogger(__name__)
 
@@ -277,6 +276,33 @@ def _log(msg, level=0):
         feature_name = None
         if event == 'feature_updated' and len(args) >= 1:
             feature_name = args[0]
+
+        # If the model was reset (None) or features referenced by viewer meshes
+        # no longer exist in the current model, remove the linkage from those
+        # meshes so they are not treated as feature-driven on subsequent updates.
+        try:
+            try:
+                current_features = {f.name for f in self.model_manager.features()}
+            except Exception:
+                current_features = set()
+
+            # If the model is None or a feature referenced by a mesh is missing,
+            # decouple that mesh from the feature so it remains visible but won't
+            # be auto-updated or re-added when the model changes.
+            for mesh_name, meta in list(self.viewer.meshes.items()):
+                sf = meta.get('source_feature', None)
+                if sf is None:
+                    continue
+                if self.model_manager.model is None or sf not in current_features:
+                    _log(f"Decoupling mesh '{mesh_name}' from missing feature '{sf}'")
+                    meta.pop('source_feature', None)
+                    meta.pop('source_type', None)
+                    meta.pop('isovalue', None)
+                    # mark as decoupled so other logic can detect it if needed
+                    meta['decoupled_from_feature'] = True
+        except Exception:
+            _log('Failed while decoupling meshes from features')
+
         # Build a set of features that currently have viewer meshes
         affected_features = set()
         for _, meta in list(self.viewer.meshes.items()):

loopstructural/main/model_manager.py

@@ -16,16 +16,16 @@
 import geopandas as gpd
 import numpy as np
 import pandas as pd
-
-from LoopStructural import GeologicalModel
 from LoopStructural.datatypes import BoundingBox
 from LoopStructural.modelling.core.fault_topology import FaultRelationshipType
 from LoopStructural.modelling.core.stratigraphic_column import StratigraphicColumn
 from LoopStructural.modelling.features import FeatureType, StructuralFrame
 from LoopStructural.modelling.features.fold import FoldFrame
-from loopstructural.toolbelt.preferences import PlgSettingsStructure
 from LoopStructural.utils.observer import Observable
 
+from LoopStructural import GeologicalModel
+from loopstructural.toolbelt.preferences import PlgSettingsStructure
+
 from ..main.helpers import qgisAttributeIsNone
 
 
@@ -482,7 +482,7 @@ def update_model(self, notify_observers: bool = True):
         # Update the model with stratigraphy
         self.update_fault_features()
         self.update_foliation_features()
-
+        
         # Notify observers using the Observable framework if requested
         if notify_observers:
             self._emit('model_updated')