diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 7a34e193b3548..56ee22b593340 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,51 +1,50 @@ -- [x] *The Jira issue number for this PR is: MDEV-______* +- [ ] *The Jira issue number for this PR is: [MDEV-_____](https://jira.mariadb.org/browse/MDEV-_____)* - ## Description TODO: fill description here + ## Release Notes TODO: What should the release notes say about this change? -Include any changed system variables, status variables or behaviour. Optionally list any https://mariadb.com/kb/ pages that need changing. - -## How can this PR be tested? + +## How to test this PR? TODO: modify the automated test suite to verify that the PR causes MariaDB to behave as intended. -Consult the documentation on ["Writing good test cases"](https://mariadb.org/get-involved/getting-started-for-developers/writing-good-test-cases-mariadb-server). +If the changes are not amenable to automated testing, please explain why and carefully describe how to test manually. -If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually. - +## Basing the PR on the correct MariaDB version -## Basing the PR against the correct MariaDB version -- [ ] *This is a new feature or a refactoring, and the PR is based against the `main` branch.* -- [ ] *This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.* +- [ ] *This is a new feature or a refactoring, and the PR is based on the `main` branch.* +- [ ] *This is a bug fix, and the PR is based on the earliest maintained branch in which the bug can be reproduced.* +## PR Quality Check -## PR quality check -- [ ] I checked the [CODING_STANDARDS.md](https://github.com/MariaDB/server/blob/-/CODING_STANDARDS.md) file and my PR conforms to this where appropriate. -- [ ] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves. +- [ ] I checked the [CODING_STANDARDS.md](https://github.com/MariaDB/server/blob/-/CODING_STANDARDS.md) file, and my PR conforms to this where appropriate. +- [ ] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves. \ No newline at end of file