Wrong command type order in README section 4.7.3.2.4

[AlexBlackfrost]

According to FMassCommandBuffer::Flush() (MassCommandBuffer.cppline 102) the order should be

Create > Remove > ChangeComposition > Add > Set > Destroy

Notice how Remove's value in CommandTypeOrder array is lower than Add's and ChangeComposition's value. It is confusing because the lines are not in order.

[Megafunk]

Huh, that is indeed the case here seeing as how it converts the index to this local constexpr array.... Good catch!!

As of 5.6 the order array is:

		MAX_int32 - 1, // None
		0, // Create
		2, // Add
		6, // Remove
		3, // ChangeComposition
		4, // Set
		6, // Destroy

I think since Remove and Destroy are the same value the order would be:

Create > ChangeComposition > Add > Set > Destroy/Remove > None

Not sure if Destroy or Remove come first, I will have to make a quick example to see what StableSort does every time. I think the intention is that it doesn't matter which order Destroy/Remove happen in here but to me it doesn't seem useful to not have a distinction...

[AlexBlackfrost]

Shouldn't Add happen before ChangeComposition?
Create > Add > ChangeComposition > Set > Destroy/Remove > None

[Megafunk]

Ack, yep. Perhaps someday I will learn to count that high...
I kind of wish they just rearranged the enum to represent the real order but there might be a reason to keep it the same if it is serialized

[AlexBlackfrost]

Yep, I agree with you.