From be5de96f65424c66aa96b550ea2486a41aff69e9 Mon Sep 17 00:00:00 2001 From: hospel Date: Thu, 2 Nov 2023 09:36:52 +0000 Subject: [PATCH 1/2] small code optimizations --- .../controller/PatientTransferController.java | 31 ++++++++++--------- .../service/PatientTransferServiceTest.java | 4 +-- .../util/fhir/OperationOutcomeUtilsTest.java | 9 +++--- 3 files changed, 23 insertions(+), 21 deletions(-) diff --git a/gpc-api-facade/src/main/java/uk/nhs/adaptors/pss/gpc/controller/PatientTransferController.java b/gpc-api-facade/src/main/java/uk/nhs/adaptors/pss/gpc/controller/PatientTransferController.java index f4d6b10d1..0b2f76322 100644 --- a/gpc-api-facade/src/main/java/uk/nhs/adaptors/pss/gpc/controller/PatientTransferController.java +++ b/gpc-api-facade/src/main/java/uk/nhs/adaptors/pss/gpc/controller/PatientTransferController.java @@ -54,6 +54,7 @@ @Validated public class PatientTransferController { + public static final String INTERNAL_SERVER_ERROR = "INTERNAL_SERVER_ERROR"; private static final String ISSUE_SYSTEM = "https://fhir.nhs.uk/STU3/ValueSet/Spine-ErrorOrWarningCode-1"; private final PatientTransferService patientTransferService; private final FhirParser fhirParser; @@ -124,7 +125,7 @@ public ResponseEntity migratePatientStructuredRecord( } private OperationOutcome createErrorBodyForInProgressRequest(String conversationId) { - var operationErrorCode = "INTERNAL_SERVER_ERROR"; + var operationErrorCode = INTERNAL_SERVER_ERROR; var operationErrorMessage = "PS - The Given NHS number is already being processed against Conversation ID: " + conversationId + ", you cannot start a new request until the current request has completed or failed."; @@ -152,15 +153,15 @@ private OperationOutcome createErrorBodyFromMigrationStatus(MigrationStatus migr + "not the patient’s current primary healthcare provider"; break; case EHR_EXTRACT_REQUEST_NEGATIVE_ACK_GP2GP_EHR_GENERATION_ERROR: - operationErrorCode = "INTERNAL_SERVER_ERROR"; + operationErrorCode = INTERNAL_SERVER_ERROR; operationErrorMessage = "GP2GP - Failed to successfully generate the EHR"; break; case EHR_EXTRACT_REQUEST_NEGATIVE_ACK_GP2GP_MULTI_OR_NO_RESPONSES: - operationErrorCode = "INTERNAL_SERVER_ERROR"; + operationErrorCode = INTERNAL_SERVER_ERROR; operationErrorMessage = "GP2GP - SDS lookup provided zero or more than one result to the query for each interaction."; break; case EHR_EXTRACT_REQUEST_NEGATIVE_ACK_UNKNOWN: - operationErrorCode = "INTERNAL_SERVER_ERROR"; + operationErrorCode = INTERNAL_SERVER_ERROR; operationErrorMessage = "GP2GP - This is a code that should only be used in circumstances where no other codes can" + " be used to accurately describe the condition."; break; @@ -169,47 +170,47 @@ private OperationOutcome createErrorBodyFromMigrationStatus(MigrationStatus migr operationErrorMessage = "GP2GP - End Point setup but GP2GP configuration switched OFF"; break; case ERROR_LRG_MSG_REASSEMBLY_FAILURE: - operationErrorCode = "INTERNAL_SERVER_ERROR"; + operationErrorCode = INTERNAL_SERVER_ERROR; operationErrorMessage = "PS - The Adaptor was unable to recombine the parts of a received attachment"; break; case ERROR_LRG_MSG_ATTACHMENTS_NOT_RECEIVED: - operationErrorCode = "INTERNAL_SERVER_ERROR"; + operationErrorCode = INTERNAL_SERVER_ERROR; operationErrorMessage = "PS - At least one attachment has not been received or could not be processed"; break; case ERROR_LRG_MSG_GENERAL_FAILURE: - operationErrorCode = "INTERNAL_SERVER_ERROR"; + operationErrorCode = INTERNAL_SERVER_ERROR; operationErrorMessage = "PS - A general processing error has occurred"; break; case ERROR_LRG_MSG_TIMEOUT: - operationErrorCode = "INTERNAL_SERVER_ERROR"; + operationErrorCode = INTERNAL_SERVER_ERROR; operationErrorMessage = "PS - An attachment was not received before a timeout condition occurred"; break; case ERROR_REQUEST_TIMEOUT: - operationErrorCode = "INTERNAL_SERVER_ERROR"; + operationErrorCode = INTERNAL_SERVER_ERROR; operationErrorMessage = "PS - The EHR record was not received within the given timeout timeframe"; break; case EHR_EXTRACT_NEGATIVE_ACK_ABA_INCORRECT_PATIENT: - operationErrorCode = "INTERNAL_SERVER_ERROR"; + operationErrorCode = INTERNAL_SERVER_ERROR; operationErrorMessage = "PS - A-B-A EHR Extract Received and rejected due to wrong record or wrong patient"; break; case EHR_EXTRACT_NEGATIVE_ACK_NON_ABA_INCORRECT_PATIENT: - operationErrorCode = "INTERNAL_SERVER_ERROR"; + operationErrorCode = INTERNAL_SERVER_ERROR; operationErrorMessage = "PS - Non A-B-A EHR Extract Received and rejected due to wrong record or wrong patient"; break; case EHR_EXTRACT_NEGATIVE_ACK_FAILED_TO_INTEGRATE: - operationErrorCode = "INTERNAL_SERVER_ERROR"; + operationErrorCode = INTERNAL_SERVER_ERROR; operationErrorMessage = "PS - Failed to successfully integrate EHR Extract"; break; case EHR_EXTRACT_NEGATIVE_ACK_SUPPRESSED: - operationErrorCode = "INTERNAL_SERVER_ERROR"; + operationErrorCode = INTERNAL_SERVER_ERROR; operationErrorMessage = "PS - A-B-A EHR Extract Received and Stored As Suppressed Record"; break; case ERROR_EXTRACT_CANNOT_BE_PROCESSED: - operationErrorCode = "INTERNAL_SERVER_ERROR"; + operationErrorCode = INTERNAL_SERVER_ERROR; operationErrorMessage = "PS - EHR Extract message not well-formed or not able to be processed"; break; default: - operationErrorCode = "INTERNAL_SERVER_ERROR"; + operationErrorCode = INTERNAL_SERVER_ERROR; operationErrorMessage = "PS - A general error has occurred"; break; } diff --git a/gpc-api-facade/src/test/java/uk/nhs/adaptors/pss/gpc/service/PatientTransferServiceTest.java b/gpc-api-facade/src/test/java/uk/nhs/adaptors/pss/gpc/service/PatientTransferServiceTest.java index 73619fbf3..a2a449113 100644 --- a/gpc-api-facade/src/test/java/uk/nhs/adaptors/pss/gpc/service/PatientTransferServiceTest.java +++ b/gpc-api-facade/src/test/java/uk/nhs/adaptors/pss/gpc/service/PatientTransferServiceTest.java @@ -99,7 +99,7 @@ public void handlePatientMigrationRequestWhenRequestIsNew() { MigrationStatusLog patientMigrationRequest = service.handlePatientMigrationRequest(parameters, HEADERS); - assertThat(patientMigrationRequest).isEqualTo(null); + assertThat(patientMigrationRequest).isNull(); verify(pssQueuePublisher).sendToPssQueue(expectedPssQueueMessage); verify(patientMigrationRequestDao).addNewRequest(PATIENT_NHS_NUMBER, CONVERSATION_ID, LOSING_ODS_CODE, WINNING_ODS_CODE); verify(migrationStatusLogDao).addMigrationStatusLog(MigrationStatus.REQUEST_RECEIVED, now, migrationRequestId, null); @@ -125,7 +125,7 @@ public void handlePatientMigrationRequestWhenRequestIsNewAndConversationIdIsLowe MigrationStatusLog patientMigrationRequest = service.handlePatientMigrationRequest(parameters, HEADERS); - assertThat(patientMigrationRequest).isEqualTo(null); + assertThat(patientMigrationRequest).isNull(); verify(pssQueuePublisher).sendToPssQueue(expectedPssQueueMessage); verify(patientMigrationRequestDao).addNewRequest(PATIENT_NHS_NUMBER, CONVERSATION_ID, LOSING_ODS_CODE, WINNING_ODS_CODE); verify(migrationStatusLogDao).addMigrationStatusLog(MigrationStatus.REQUEST_RECEIVED, now, migrationRequestId, null); diff --git a/gpc-api-facade/src/test/java/uk/nhs/adaptors/pss/gpc/util/fhir/OperationOutcomeUtilsTest.java b/gpc-api-facade/src/test/java/uk/nhs/adaptors/pss/gpc/util/fhir/OperationOutcomeUtilsTest.java index d6463613e..21bf5de86 100644 --- a/gpc-api-facade/src/test/java/uk/nhs/adaptors/pss/gpc/util/fhir/OperationOutcomeUtilsTest.java +++ b/gpc-api-facade/src/test/java/uk/nhs/adaptors/pss/gpc/util/fhir/OperationOutcomeUtilsTest.java @@ -3,6 +3,7 @@ import static org.assertj.core.api.AssertionsForClassTypes.assertThat; import static org.hl7.fhir.dstu3.model.OperationOutcome.IssueSeverity.ERROR; import static org.hl7.fhir.dstu3.model.OperationOutcome.IssueType.NOTSUPPORTED; +import static org.junit.jupiter.api.Assertions.assertEquals; import org.hl7.fhir.dstu3.model.CodeableConcept; import org.hl7.fhir.dstu3.model.OperationOutcome; @@ -21,10 +22,10 @@ public void testCreateOperationOutcome() { OperationOutcome result = OperationOutcomeUtils.createOperationOutcome(NOTSUPPORTED, ERROR, details, diagnostics); assertThat(result.getMeta().getProfile().get(0).equals(URI_TYPE)).isTrue(); - assertThat(result.getIssueFirstRep().getCode()).isEqualTo(NOTSUPPORTED); - assertThat(result.getIssueFirstRep().getSeverity()).isEqualTo(ERROR); - assertThat(result.getIssueFirstRep().getDetails()).isEqualTo(details); - assertThat(result.getIssueFirstRep().getDiagnostics()).isEqualTo(diagnostics); + assertEquals(NOTSUPPORTED, result.getIssueFirstRep().getCode()); + assertEquals(ERROR, result.getIssueFirstRep().getSeverity()); + assertEquals(details, result.getIssueFirstRep().getDetails()); + assertEquals(diagnostics, result.getIssueFirstRep().getDiagnostics()); } private CodeableConcept createCodeableConcept() { From cea4a2143653a207d30c84258c85b3f67c432360 Mon Sep 17 00:00:00 2001 From: hospel <12736698+ole4ryb@users.noreply.github.com> Date: Wed, 13 Aug 2025 11:41:42 +0100 Subject: [PATCH 2/2] small code improvements --- .../mapper/CodeableConceptMapperTest.java | 18 ++++++----------- .../diagnosticreport/SpecimenMapperTest.java | 4 ++-- .../MedicationRequestMapperTest.java | 20 +++++++++---------- .../SkeletonProcessingServiceTests.java | 14 ++++++------- .../src/test/java/Gp2GpAdaptorSmokeTest.java | 2 +- 5 files changed, 26 insertions(+), 32 deletions(-) diff --git a/gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/mapper/CodeableConceptMapperTest.java b/gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/mapper/CodeableConceptMapperTest.java index f3581b76c..eaf01500d 100644 --- a/gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/mapper/CodeableConceptMapperTest.java +++ b/gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/mapper/CodeableConceptMapperTest.java @@ -323,8 +323,7 @@ public void mapSnomedCodeWithDescriptionIdDescriptionIsPreferredTerm() { .isEqualTo(SNOMED_PREFERRED.getConceptid()); assertThat(codeableConcept.getCoding().getFirst().getDisplay()) .isEqualTo(SNOMED_PREFERRED.getTerm()); - assertThat(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().size() == 1) - .isTrue(); + assertTrue(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().size() == 1); assertThat(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().getFirst().getUrl()) .isEqualTo(DESCRIPTION_ID); assertThat(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().getFirst().getValue()) @@ -349,8 +348,7 @@ public void mapSnomedCodeWithDescriptionIdPreferredTermDisplayMatchesTermNoOrigi .isEqualTo(SNOMED_PREFERRED.getConceptid()); assertThat(codeableConcept.getCoding().getFirst().getDisplay()) .isEqualTo(SNOMED_PREFERRED.getTerm()); - assertThat(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().size() == 1) - .isTrue(); + assertTrue(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().size() == 1); assertThat(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().getFirst().getUrl()) .isEqualTo(DESCRIPTION_ID); assertThat(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().getFirst().getValue()) @@ -373,8 +371,7 @@ public void mapSnomedCodeWithDescriptionIdPreferredTermDisplayDoesNotMatchTermNo assertEquals(SNOMED_PREFERRED.getConceptid(), codeableConcept.getCoding().getFirst().getCode()); assertEquals(SNOMED_PREFERRED.getTerm(), codeableConcept.getCoding().getFirst().getDisplay()); - assertThat(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().size() == 1) - .isTrue(); + assertTrue(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().size() == 1); assertThat(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().getFirst().getUrl()) .isEqualTo(DESCRIPTION_ID); assertThat(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().getFirst().getValue()) @@ -401,8 +398,7 @@ public void mapSnomedCodeWithDescriptionIdDescriptionIsNotPreferredTerm() { .isEqualTo(SNOMED_DESCRIPTION.getConceptid()); assertThat(codeableConcept.getCoding().getFirst().getDisplay()) .isEqualTo(SNOMED_PREFERRED.getTerm()); - assertThat(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().size() == 2) - .isTrue(); + assertTrue(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().size() == 2); assertThat(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().getFirst().getUrl()) .isEqualTo(DESCRIPTION_ID); assertThat(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().getFirst().getValue()) @@ -431,8 +427,7 @@ public void mapSnomedCodeWithDescriptionIdNotPreferredTermDisplayMatchesTermNoOr .isEqualTo(SNOMED_DESCRIPTION.getConceptid()); assertThat(codeableConcept.getCoding().getFirst().getDisplay()) .isEqualTo(SNOMED_PREFERRED.getTerm()); - assertThat(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().size() == 2) - .isTrue(); + assertTrue(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().size() == 2); assertThat(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().getFirst().getUrl()) .isEqualTo(DESCRIPTION_ID); assertThat(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().getFirst().getValue()) @@ -460,8 +455,7 @@ public void mapSnomedCodeWithDescriptionIdNotPreferredTermDisplayDoesNotMatchTer .isEqualTo(SNOMED_DESCRIPTION.getConceptid()); assertThat(codeableConcept.getCoding().getFirst().getDisplay()) .isEqualTo(SNOMED_PREFERRED.getTerm()); - assertThat(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().size() == 2) - .isTrue(); + assertTrue(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().size() == 2); assertThat(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().getFirst().getUrl()) .isEqualTo(DESCRIPTION_ID); assertThat(codeableConcept.getCoding().getFirst().getExtension().getFirst().getExtension().getFirst().getValue()) diff --git a/gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/mapper/diagnosticreport/SpecimenMapperTest.java b/gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/mapper/diagnosticreport/SpecimenMapperTest.java index 279c770b1..2dbbae500 100644 --- a/gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/mapper/diagnosticreport/SpecimenMapperTest.java +++ b/gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/mapper/diagnosticreport/SpecimenMapperTest.java @@ -37,7 +37,7 @@ import uk.nhs.adaptors.pss.translator.service.ConfidentialityService; @ExtendWith(MockitoExtension.class) -public class SpecimenMapperTest { +class SpecimenMapperTest { private static final String XML_RESOURCES_BASE = "xml/Specimen/"; private static final String SPECIMEN_PREFIX = "Specimen/"; @@ -128,7 +128,7 @@ void testSpecimenIsMapped() { assertThat(specimen.getNote().getFirst().getText()).isEqualTo(NOTE_TEXT); assertThat(specimen.getAccessionIdentifier().getValue()).isEqualTo(ACCESSION_IDENTIFIER_VALUE); assertThat(specimen.getType().getText()).isEqualTo(SPECIMEN_TYPE_TEXT); - assertThat(specimen.getCollection().getCollected().toString()).isEqualTo(SPECIMEN_COLLECTED_DATETIME.toString()); + assertThat(specimen.getCollection().getCollected()).hasToString(String.valueOf(SPECIMEN_COLLECTED_DATETIME)); } @Test diff --git a/gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/mapper/medication/MedicationRequestMapperTest.java b/gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/mapper/medication/MedicationRequestMapperTest.java index 46d6d6aba..f65a20ebc 100644 --- a/gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/mapper/medication/MedicationRequestMapperTest.java +++ b/gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/mapper/medication/MedicationRequestMapperTest.java @@ -140,19 +140,19 @@ public void When_MappingMedicationStatement_Expect_CorrectMappersToBeCalled() { .mapResources(ehrExtract, (Patient) new Patient().setId(PATIENT_ID), List.of(), PRACTISE_CODE); verify(medicationRequestPlanMapper, times(SINGLE_INVOCATION)).mapToPlanMedicationRequest( - eq(ehrExtract), - eq(ehrComposition), - eq(medicationStatement), - eq(medicationStatement.getComponent().getFirst().getEhrSupplyAuthorise()), - eq(PRACTISE_CODE) + ehrExtract, + ehrComposition, + medicationStatement, + medicationStatement.getComponent().getFirst().getEhrSupplyAuthorise(), + PRACTISE_CODE ); verify(medicationRequestOrderMapper, times(SINGLE_INVOCATION)).mapToOrderMedicationRequest( - eq(ehrExtract), - eq(ehrComposition), - eq(medicationStatement), - eq(medicationStatement.getComponent().get(2).getEhrSupplyPrescribe()), - eq(PRACTISE_CODE) + ehrExtract, + ehrComposition, + medicationStatement, + medicationStatement.getComponent().get(2).getEhrSupplyPrescribe(), + PRACTISE_CODE ); verify(medicationStatementMapper, times(SINGLE_INVOCATION)).mapToMedicationStatement( diff --git a/gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/service/SkeletonProcessingServiceTests.java b/gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/service/SkeletonProcessingServiceTests.java index 04218ab76..c180fb13a 100644 --- a/gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/service/SkeletonProcessingServiceTests.java +++ b/gp2gp-translator/src/test/java/uk/nhs/adaptors/pss/translator/service/SkeletonProcessingServiceTests.java @@ -39,7 +39,7 @@ import uk.nhs.adaptors.pss.translator.util.XmlParseUtilService; @ExtendWith(MockitoExtension.class) -public class SkeletonProcessingServiceTests { +class SkeletonProcessingServiceTests { private static final String CONVERSATION_ID = randomUUID().toString(); private static final String NHS_NUMBER = "1111"; @@ -112,7 +112,7 @@ private void prepareSkeletonRCMRMocks(InboundMessage inboundMessage) throws Tran } @Test - public void When_UpdateInboundMessageAttachmentHandlerServiceThrowsIllegalArgumentException_Expect_ThrowsException() { + void When_UpdateInboundMessageAttachmentHandlerServiceThrowsIllegalArgumentException_Expect_ThrowsException() { var inboundMessage = new InboundMessage(); var attachmentLog = createSkeletonPatientAttachmentLog(); @@ -128,7 +128,7 @@ public void When_UpdateInboundMessageAttachmentHandlerServiceThrowsIllegalArgume } @Test - public void When_HappyPathWithSkeletonAsRCMRMessage_Expect_ThrowNoErrors() throws TransformerException, + void When_HappyPathWithSkeletonAsRCMRMessage_Expect_ThrowNoErrors() throws TransformerException, SAXException { var inboundMessage = new InboundMessage(); var attachmentLog = createSkeletonPatientAttachmentLog(); @@ -142,7 +142,7 @@ public void When_HappyPathWithSkeletonAsRCMRMessage_Expect_ThrowNoErrors() throw } @Test - public void When_HappyPathWithSkeletonAsRCMRMessage_Expect_InboundMessagePayloadIsNewRCMRMessage() + void When_HappyPathWithSkeletonAsRCMRMessage_Expect_InboundMessagePayloadIsNewRCMRMessage() throws TransformerException, SAXException { var inboundMessage = new InboundMessage(); var attachmentLog = createSkeletonPatientAttachmentLog(); @@ -159,7 +159,7 @@ public void When_HappyPathWithSkeletonAsRCMRMessage_Expect_InboundMessagePayload } @Test - public void When_HappyPathWithSkeletonAsSectionMessage_Expect_ThrowNoErrors() + void When_HappyPathWithSkeletonAsSectionMessage_Expect_ThrowNoErrors() throws TransformerException, SAXException { var inboundMessage = new InboundMessage(); var attachmentLog = createSkeletonPatientAttachmentLog(); @@ -173,7 +173,7 @@ public void When_HappyPathWithSkeletonAsSectionMessage_Expect_ThrowNoErrors() } @Test - public void When_SkeletonAsSectionMessage_Expect_ThrowNoErrors() throws TransformerException, SAXException { + void When_SkeletonAsSectionMessage_Expect_ThrowNoErrors() throws TransformerException, SAXException { var inboundMessage = new InboundMessage(); var attachmentLog = createSkeletonPatientAttachmentLog(); @@ -185,7 +185,7 @@ public void When_SkeletonAsSectionMessage_Expect_ThrowNoErrors() throws Transfor } @Test - public void When_SkeletonAsSectionMessageAndEBXMLSkeletonReferenceIsEmpty_Expect_IllegalArgumentException() + void When_SkeletonAsSectionMessageAndEBXMLSkeletonReferenceIsEmpty_Expect_IllegalArgumentException() throws SAXException { var inboundMessage = new InboundMessage(); var attachmentLog = createSkeletonPatientAttachmentLog(); diff --git a/smoke-tests/src/test/java/Gp2GpAdaptorSmokeTest.java b/smoke-tests/src/test/java/Gp2GpAdaptorSmokeTest.java index 3cdc36f73..6adf9fc15 100644 --- a/smoke-tests/src/test/java/Gp2GpAdaptorSmokeTest.java +++ b/smoke-tests/src/test/java/Gp2GpAdaptorSmokeTest.java @@ -36,7 +36,7 @@ public static void setup() { } @Test - public void expect_Gp2gpAdaptorIsAvailable() { + void expect_Gp2gpAdaptorIsAvailable() { Optional responseBody = Optional.empty();