Skip to content

Commit 06ac41d

Browse files
committed
[PRMP-1085] Update failure reasons in document review tests to use DocumentReviewReason enum
1 parent 2d0c92b commit 06ac41d

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

lambdas/tests/unit/handlers/test_document_review_processor_handler.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import json
22

33
import pytest
4+
5+
from enums.document_review_reason import DocumentReviewReason
46
from handlers.document_review_processor_handler import lambda_handler
57
from models.sqs.review_message_body import ReviewMessageBody, ReviewMessageFile
68

@@ -27,7 +29,7 @@ def sample_review_message_body():
2729
)
2830
],
2931
nhs_number="9000000009",
30-
failure_reason="Failed virus scan",
32+
failure_reason=DocumentReviewReason.GENERAL_ERROR,
3133
upload_date="2024-01-15T10:30:00Z",
3234
uploader_ods="Y12345",
3335
current_gp="Y12345",
@@ -62,7 +64,7 @@ def sample_sqs_event_multiple_messages(sample_review_message_body):
6264
)
6365
],
6466
nhs_number="9000000009",
65-
failure_reason="Failed virus scan",
67+
failure_reason=DocumentReviewReason.UNKNOWN_NHS_NUMBER,
6668
upload_date="2024-01-15T10:30:00Z",
6769
uploader_ods="Y12345",
6870
current_gp="Y12345",
@@ -77,7 +79,7 @@ def sample_sqs_event_multiple_messages(sample_review_message_body):
7779
)
7880
],
7981
nhs_number="9000000010",
80-
failure_reason="Invalid file format",
82+
failure_reason=DocumentReviewReason.FILE_NAME_MISMATCH,
8183
upload_date="2024-01-15T10:35:00Z",
8284
uploader_ods="Y12345",
8385
current_gp="Y12345",
@@ -92,7 +94,7 @@ def sample_sqs_event_multiple_messages(sample_review_message_body):
9294
)
9395
],
9496
nhs_number="9000000011",
95-
failure_reason="Missing metadata",
97+
failure_reason=DocumentReviewReason.FILE_COUNT_MISMATCH,
9698
upload_date="2024-01-15T10:40:00Z",
9799
uploader_ods="Y67890",
98100
current_gp="Y67890",
@@ -194,7 +196,7 @@ def test_lambda_handler_parses_json_body_correctly(
194196
{"file_name": "test.pdf", "file_path": "staging/test.pdf"}
195197
],
196198
"nhs_number": "9000000009",
197-
"failure_reason": "Test failure",
199+
"failure_reason": "General error",
198200
"upload_date": "2024-01-15T10:30:00Z",
199201
"uploader_ods": "Y12345",
200202
"current_gp": "Y12345",

0 commit comments

Comments
 (0)