add file type check for review docs

Author: kamenbachvarov-nhs

lambdas/enums/lambda_error.py

@@ -517,6 +517,10 @@ def create_error_body(self, params: Optional[dict] = None, **kwargs) -> str:
         "err_code": "DRV_4005",
         "message": "The NHS number provided is invalid",
     }
+    DocumentReviewUnsupportedFileType = {
+        "err_code": "DRV_4006",
+        "message": "The file type provided is not supported",
+    }
 
     """
        Errors for get ods report lambda 
@@ -690,10 +694,7 @@ def create_error_body(self, params: Optional[dict] = None, **kwargs) -> str:
         "message": "Invalid request",
     }
 
-    DocumentReviewUploadForbidden = {
-        "err_code": "UDR_4031",
-        "message": "Forbidden"
-    }
+    DocumentReviewUploadForbidden = {"err_code": "UDR_4031", "message": "Forbidden"}
 
     DocumentReviewPresignedFailure = {
         "err_code": "UDR_5003",

lambdas/services/post_document_review_service.py

@@ -6,6 +6,7 @@
 from enums.document_review_status import DocumentReviewReason, DocumentReviewStatus
 from enums.lambda_error import LambdaError
 from enums.patient_ods_inactive_status import PatientOdsInactiveStatus
+from enums.upload_forbidden_file_extensions import is_file_type_allowed
 from models.document_review import (
     DocumentReviewFileDetails,
     DocumentReviewUploadEvent,
@@ -14,8 +15,10 @@
 from pydantic import ValidationError
 from services.base.s3_service import S3Service
 from services.document_upload_review_service import DocumentUploadReviewService
+from utils import upload_file_configs
 from utils.audit_logging_setup import LoggingService
 from utils.exceptions import (
+    ConfigNotFoundException,
     DocumentReviewException,
     OdsErrorException,
     PatientNotFoundException,
@@ -51,6 +54,8 @@ def process_event(self, event: DocumentReviewUploadEvent) -> dict:
                     403, LambdaError.DocumentReviewUploadForbidden
                 )
 
+            self.validate_document_file_type(event)
+
             document_review_reference = self.create_review_reference_from_event(
                 event=event, author=author, patient_details=patient_details
             )
@@ -84,6 +89,27 @@ def process_event(self, event: DocumentReviewUploadEvent) -> dict:
         except ClientError:
             raise DocumentReviewLambdaException(500, LambdaError.DocumentReviewDB)
 
+    def validate_document_file_type(self, event: DocumentReviewUploadEvent) -> None:
+        snomed_code = event.snomed_code.code
+        accepted_file_types = self.get_accepted_file_types(
+            snomed_code, upload_file_configs
+        )
+
+        if not is_file_type_allowed(event.documents[0], accepted_file_types):
+            logger.info("File type is not supported.")
+            raise DocumentReviewLambdaException(
+                400, LambdaError.DocumentReviewUnsupportedFileType
+            )
+
+    def get_accepted_file_types(self, snomed_code, upload_file_configs):
+        try:
+            return upload_file_configs.get_config_by_snomed_code(
+                snomed_code
+            ).accepted_file_types
+        except ConfigNotFoundException:
+            logger.error(f"Unable to find config for snomed code: {snomed_code}")
+            raise DocumentReviewLambdaException(400, LambdaError.DocRefInvalidType)
+
     def create_response(
         self, document_review_reference: DocumentUploadReviewReference
     ) -> dict:

lambdas/tests/unit/services/test_post_document_review_service.py

@@ -294,3 +294,39 @@ def test_create_response(mock_service):
         )
     )
     assert actual == expected
+
+
+@freeze_time("2024-01-01 12:00:00")
+def test_validate_file_type_with_invalid_file_type(mock_extract_ods, mock_service):
+    mock_extract_ods.return_value = TEST_CURRENT_GP_ODS
+    mock_service.pds_service.fetch_patient_details.return_value = (
+        EXPECTED_PARSED_PATIENT_BASE_CASE
+    )
+    invalid_event = deepcopy(VALID_EVENT)
+    invalid_event.documents = ["testFile.exe"]
+
+    with pytest.raises(DocumentReviewLambdaException) as e:
+        mock_service.process_event(invalid_event)
+
+    assert e.value.status_code == 400
+    assert e.value.err_code == "DRV_4006"
+
+    mock_service.review_document_service.create_dynamo_entry.assert_not_called()
+
+
+@freeze_time("2024-01-01 12:00:00")
+def test_validate_file_type_with_invalid_snomed_code(mock_extract_ods, mock_service):
+    mock_extract_ods.return_value = TEST_CURRENT_GP_ODS
+    mock_service.pds_service.fetch_patient_details.return_value = (
+        EXPECTED_PARSED_PATIENT_BASE_CASE
+    )
+    invalid_event = deepcopy(VALID_EVENT)
+    invalid_event.snomed_code.code = "INVALID_SNOMED_CODE"
+
+    with pytest.raises(DocumentReviewLambdaException) as e:
+        mock_service.process_event(invalid_event)
+
+    assert e.value.status_code == 400
+    assert e.value.err_code == "DR_4007"
+
+    mock_service.review_document_service.create_dynamo_entry.assert_not_called()

lambdas/tests/unit/services/test_post_fhir_document_reference_service.py

@@ -549,7 +549,7 @@ def test_extract_author_from_fhir(
     ],
 )
 def test_extract_author_from_fhir_raises_error(
-    mock_post_fhir_doc_ref_service, mocker, fhir_author
+    mock_fhir_doc_ref_base_service, mock_post_fhir_doc_ref_service, mocker, fhir_author
 ):
     """Test _extract_author_from_fhir method with malformed json returns Validation errors."""
     fhir_doc = mocker.MagicMock(spec=FhirDocumentReference)