Backport upstream notifications fix for Nextcloud 33.0.4.1

[grisey]

Affected version

• ghcr.io/nethserver/nextcloud-app:1.7.1
• Nextcloud 33.0.4.1
• notifications app 6.0.0

Issue

After the update to Nextcloud 33.0.4.1, OCM / Federated Talk share creation fails with HTTP 500.

Observed log entry:

[nextcloud][PHP][2] {"method":"POST","url":"/ocm/shares","message":"Undefined property: OCA\\Notifications\\Push::$appConfig at /var/www/html/apps/notifications/lib/Push.php#644","userAgent":"Nextcloud-Server-Crawler/33.0.4","version":"33.0.4.1"}
127.0.0.1 - "POST /index.php" 500

Relevant installed apps:

cloud_federation_api: 1.17.0
federation: 1.23.0
lookup_server_connector: 1.21.0
notifications: 6.0.0
notify_push: 1.3.3
spreed: 23.0.6

Upstream

This matches the upstream Nextcloud Notifications issue:

• [BUG]: Push notifications broken | v32.0.10, v33.0.4 | Error: Call to a member function getAppValueString() on null nextcloud/notifications#3035
• Bug Report: notifications app 6.0.0 — $appConfig not injected in Push constructor, crashes Talk calls with HTTP 500 nextcloud/notifications#3056

Could the upstream fix be included in the next ns8-nextcloud image build?

[stephdl]

Could the upstream fix be included in the next ns8-nextcloud image build?

once released in dockerhub

[grisey]

Could the upstream fix be included in the next ns8-nextcloud image build?

once released in dockerhub

Thanks — Isn`t this the image containing the fix:

https://hub.docker.com/_/nextcloud/tags?name=33.0.5-fpm-alpine

[stephdl]

yes it is NethServer/ns8-nextcloud#234

[stephdl]

QA

• test the upgrade to the version nextcloud:1.7.2-dev.3 (nextcloud 33.0.5)
• verify basic file service functions are workable
• verify the issue above is fixed

adapt nextcloud1 to your module_id instance for upgrade

api-cli run update-module --data '{"module_url":"ghcr.io/nethserver/nextcloud:1.7.2-dev.3","instances":["nextcloud1"],"force":true}'