refactor(server): remove polka and use find-my-way + native HTTP

Update workspaces/server/src/endpoints/report.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update workspaces/server/src/endpoints/util/send.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

chore: fix review

Author: fraxken

src/commands/http.js

@@ -64,7 +64,7 @@ export async function start(
   });
 
   httpServer.listen(httpPort, async() => {
-    const link = `http://localhost:${httpServer.server.address().port}`;
+    const link = `http://localhost:${httpServer.address().port}`;
     console.log(kleur.magenta().bold(await i18n.getToken("cli.http_server_started")), kleur.cyan().bold(link));
 
     open(link);
@@ -77,7 +77,7 @@ export async function start(
 
   for (const eventName of ["SIGINT", "SIGTERM"]) {
     process.on(eventName, () => {
-      httpServer.server.close();
+      httpServer.close();
 
       console.log(kleur.red().bold(`${eventName} signal received.`));
       process.exit(0);

test/helpers/utils.js

@@ -1,11 +1,11 @@
-export function getExpectedScorecardLines(pkgName, body) {
+export function getExpectedScorecardLines(packageName, body) {
   const { date, score: scorePkg, checks } = body;
 
   const expectedLines = [
     "",
     "                                 OSSF Scorecard",
     "",
-    mockScorecardCliLine("Repository", pkgName),
+    mockScorecardCliLine("Repository", packageName),
     mockScorecardCliLine("Scan at", date),
     mockScorecardCliLine("Score", scorePkg),
     "--------------------------------------------------------------------------------"

workspaces/server/README.md

@@ -126,31 +126,31 @@ Get the HTML description for a specific flag.
 **Params**:
 - `title`: The flag name.
 
-- `GET /bundle/:pkgName`
+- `GET /bundle/:packageName`
 Get bundle size information for a package from Bundlephobia.
 
 **Params**:
-- `pkgName`: The npm package name.
+- `packageName`: The npm package name.
 
-- `GET /bundle/:pkgName/:version`
+- `GET /bundle/:packageName/:version`
 Get bundle size information for a specific version of a package from Bundlephobia.
 
 **Params**:
-- `pkgName`: The npm package name.
+- `packageName`: The npm package name.
 - `version`: The package version.
 
-- `GET /downloads/:pkgName`
+- `GET /downloads/:packageName`
 Get npm download statistics for the last week for a package.
 
 **Params**:
-- `pkgName`: The npm package name.
+- `packageName`: The npm package name.
 
-- `GET /scorecard/:org/:pkgName`
+- `GET /scorecard/:org/:packageName`
 Get OSSF Scorecard results for a package repository.
 
 **Params**:
 - `org`: The organization or user.
-- `pkgName`: The repository name.
+- `packageName`: The repository name.
 
 **Query**:
 `platform` (*optional*): The platform (default: `github.com`).

workspaces/server/package.json

@@ -18,20 +18,18 @@
   "author": "GENTILHOMME Thomas <gentilhomme.thomas@gmail.com>",
   "license": "MIT",
   "devDependencies": {
-    "@polka/send-type": "0.5.2",
-    "@types/polka": "^0.5.7",
     "@types/server-destroy": "^1.0.4",
-    "@types/ws": "^8.18.1"
+    "@types/ws": "^8.18.1",
+    "server-destroy": "1.0.1"
   },
   "dependencies": {
     "@nodesecure/cache": "1.0.0",
     "cacache": "20.0.3",
     "chokidar": "5.0.0",
+    "find-my-way": "9.3.0",
     "glob": "13.0.0",
     "pino": "10.1.0",
     "pino-pretty": "13.1.2",
-    "polka": "0.5.2",
-    "server-destroy": "1.0.1",
     "sirv": "3.0.2",
     "ts-pattern": "5.9.0",
     "ws": "8.18.3",

workspaces/server/src/ALS.ts

@@ -2,6 +2,19 @@
 import { AsyncLocalStorage } from "node:async_hooks";
 
 // Import Internal Dependencies
-import type { AyncStoreContext } from "./middlewares/context.ts";
+import type { ViewBuilder } from "./ViewBuilder.class.ts";
 
-export const context = new AsyncLocalStorage<AyncStoreContext>();
+export type NestedStringRecord = {
+  [key: string]: string | NestedStringRecord;
+};
+
+export interface AsyncStoreContext {
+  dataFilePath?: string;
+  i18n: {
+    english: NestedStringRecord;
+    french: NestedStringRecord;
+  };
+  viewBuilder: ViewBuilder;
+}
+
+export const context = new AsyncLocalStorage<AsyncStoreContext>();

workspaces/server/src/endpoints/bundle.ts

@@ -1,7 +1,14 @@
+// Import Node.js Dependencies
+import type {
+  IncomingMessage,
+  ServerResponse
+} from "node:http";
+
 // Import Third-party Dependencies
 import * as httpie from "@openally/httpie";
-import send from "@polka/send-type";
-import type { Request, Response } from "express-serve-static-core";
+
+// Import Internal Dependencies
+import { send } from "./util/send.ts";
 
 // CONSTANTS
 const kBaseBundlePhobiaUrl = "https://bundlephobia.com/api";
@@ -15,21 +22,34 @@ interface BundlePhobiaResponse {
   }[];
 }
 
-export async function get(req: Request, res: Response) {
-  const { pkgName, version } = req.params;
+export async function get(
+  _: IncomingMessage,
+  res: ServerResponse,
+  params: Record<string, string | undefined>
+) {
+  const { packageName, version } = params;
+  if (!packageName) {
+    return send(res, {
+      error: "Package name is missing."
+    }, { code: 400 });
+  }
 
-  const pkgTemplate = version ? `${pkgName.replaceAll("%2F", "/")}@${version}` : pkgName;
+  const pkgTemplate = version ?
+    `${packageName.replaceAll("%2F", "/")}@${version}` :
+    packageName;
   try {
     const { data } = await httpie.get<BundlePhobiaResponse>(`${kBaseBundlePhobiaUrl}/size?package=${pkgTemplate}`);
     const { gzip, size, dependencySizes } = data;
 
-    return send(res, 200, {
+    return send(res, {
       gzip,
       size,
       dependencySizes
     });
   }
   catch (error: any) {
-    return send(res, error.statusCode, { error: error.statusMessage });
+    return send(res, { error: error.statusMessage }, {
+      code: error.statusCode ?? 500
+    });
   }
 }

workspaces/server/src/endpoints/config.ts

@@ -1,20 +1,33 @@
+// Import Node.js Dependencies
+import type {
+  IncomingMessage,
+  ServerResponse
+} from "node:http";
+
 // Import Third-party Dependencies
-import send from "@polka/send-type";
-import type { Request, Response } from "express-serve-static-core";
+import type { AppConfig } from "@nodesecure/cache";
 
 // Import Internal Dependencies
 import * as config from "../config.ts";
-import { bodyParser } from "../middlewares/bodyParser.ts";
+import { bodyParser } from "./util/bodyParser.ts";
+import { send } from "./util/send.ts";
 
-export async function get(_req: Request, res: Response) {
+export async function get(
+  _req: IncomingMessage,
+  res: ServerResponse
+) {
   const result = await config.get();
 
-  send(res, 200, result);
+  send(res, result);
 }
 
-export async function save(req: Request, res: Response) {
-  const data = await bodyParser(req);
+export async function save(
+  req: IncomingMessage,
+  res: ServerResponse
+) {
+  const data = await bodyParser<AppConfig>(req);
   await config.set(data);
 
-  send(res, 204);
+  res.statusCode = 204;
+  res.end();
 }

workspaces/server/src/endpoints/data.ts

@@ -1,23 +1,28 @@
 // Import Node.js Dependencies
 import fs from "node:fs";
 import path from "node:path";
-
-// Import Third-party Dependencies
-import send from "@polka/send-type";
-import type { Request, Response } from "express-serve-static-core";
+import type {
+  IncomingMessage,
+  ServerResponse
+} from "node:http";
 
 // Import Internal Dependencies
 import { context } from "../ALS.ts";
 import { logger } from "../logger.ts";
 import { cache } from "../cache.ts";
+import { send } from "./util/send.ts";
 
 // CONSTANTS
 const kDefaultPayloadPath = path.join(process.cwd(), "nsecure-result.json");
 
-export async function get(_req: Request, res: Response) {
+export async function get(
+  _req: IncomingMessage,
+  res: ServerResponse
+) {
   if (cache.startFromZero) {
     logger.info("[data|get](no content)");
-    send(res, 204);
+    res.statusCode = 204;
+    res.end();
 
     return;
   }
@@ -27,7 +32,7 @@ export async function get(_req: Request, res: Response) {
     logger.info(`[data|get](current: ${current})`);
     logger.debug(`[data|get](lru: ${mru})`);
 
-    send(res, 200, cache.getPayload(current));
+    send(res, cache.getPayload(current));
   }
   catch {
     logger.error("[data|get](No cache yet. Creating one...)");
@@ -55,6 +60,6 @@ export async function get(_req: Request, res: Response) {
     cache.updatePayload(formatted, payload);
     logger.info(`[data|get](cache: created|payloadsList: ${payloadsList.lru})`);
 
-    send(res, 200, payload);
+    send(res, payload);
   }
 }

workspaces/server/src/endpoints/flags.ts

@@ -1,26 +1,58 @@
 // Import Node.js Dependencies
 import stream from "node:stream";
+import type {
+  IncomingMessage,
+  ServerResponse
+} from "node:http";
 
 // Import Third-party Dependencies
-import send from "@polka/send-type";
-import { getManifest, lazyFetchFlagFile, getFlags } from "@nodesecure/flags";
-import type { Request, Response } from "express-serve-static-core";
+import {
+  getManifest,
+  lazyFetchFlagFile,
+  getFlags
+} from "@nodesecure/flags";
+
+// Import Internal Dependencies
+import { send } from "./util/send.ts";
 
 // CONSTANTS
 const kNodeSecureFlags = getFlags();
 
-export function getAll(_req, res) {
-  send(res, 200, getManifest());
+export function getAll(
+  _req: IncomingMessage,
+  res: ServerResponse
+) {
+  send(res, getManifest());
 }
 
-export function get(req: Request, res: Response) {
-  if (req.params.title !== "hasDuplicate" && !kNodeSecureFlags.has(req.params.title)) {
-    return send(res, 404, { error: "Not Found" });
+export function get(
+  _: IncomingMessage,
+  res: ServerResponse,
+  params: Record<string, string | undefined>
+) {
+  const { title } = params;
+  if (!title) {
+    return send(
+      res,
+      { error: "Title is missing." },
+      { code: 400 }
+    );
+  }
+
+  if (
+    title !== "hasDuplicate" &&
+    !kNodeSecureFlags.has(title)
+  ) {
+    return send(
+      res,
+      { error: "Not Found" },
+      { code: 404 }
+    );
   }
 
   res.writeHead(200, { "Content-Type": "text/html" });
 
-  return stream.pipeline(lazyFetchFlagFile(req.params.title), res, (err) => {
+  return stream.pipeline(lazyFetchFlagFile(title), res, (err) => {
     if (err) {
       console.error(err);
     }

workspaces/server/src/endpoints/i18n.ts

@@ -1,15 +1,21 @@
-// Import Third-party Dependencies
-import send from "@polka/send-type";
+// Import Node.js Dependencies
+import type {
+  IncomingMessage,
+  ServerResponse
+} from "node:http";
 
 // Import Internal Dependencies
 import { context } from "../ALS.ts";
+import { send } from "./util/send.ts";
 
-export async function get(_req, res) {
+export async function get(
+  _req: IncomingMessage,
+  res: ServerResponse
+) {
   const { i18n } = context.getStore()!;
 
   send(
     res,
-    200,
     {
       english: i18n.english.ui,
       french: i18n.french.ui