Skip to content

fix(x402): verifier replicas: 2 → 1 to keep metric GC correct #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bussyjd wants to merge 1 commit into from
+5 −13
Closed

fix(x402): verifier replicas: 2 → 1 to keep metric GC correct #515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions internal/embed/infrastructure/base/templates/x402.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,11 @@ metadata:
labels:
app: x402-verifier
spec:
replicas: 2
# Single replica — verifier holds per-pod metric registries and per-pod
# informer caches; multiple replicas produce metric series drift across
# ServiceMonitor scrape rotations and the pruneSeriesNotIn GC (metrics.go)
# becomes inconsistent. Single-node k3d gains no HA from 2 replicas.
replicas: 1
selector:
matchLabels:
app: x402-verifier
Expand Down Expand Up @@ -321,18 +325,6 @@ spec:
targetPort: http
protocol: TCP

---
apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
name: x402-verifier
namespace: x402
spec:
minAvailable: 1
selector:
matchLabels:
app: x402-verifier

---
# ServiceMonitor for x402-verifier — scrapes the stable Service endpoint
# rather than per-pod IPs (which is what a PodMonitor would do). Lives
Expand Down