Skip to content

fix(prometheus-rules): escape PromQL $labels for Helm rendering #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bussyjd wants to merge 1 commit into from
+10 −9
Closed

fix(prometheus-rules): escape PromQL $labels for Helm rendering #527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions internal/embed/infrastructure/base/templates/x402-prometheus-rules.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,11 @@ spec:
increase(obol_x402_verifier_charged_requests_total[7d])
)

# Lifetime charged-request count per offer (sum across replicas
# + chains). Used in the My Listings "today · X earned" header
# text and the Browse catalog usage badge.
- record: x402:revenue:lifetime_by_offer
# Sum of currently-running verifier replicas' counters — resets
# on rollout; for true lifetime, query against a long-retention
# store or use `sum_over_time(...[Nd])`. Used in the My Listings
# "today · X earned" header text and the Browse catalog usage badge.
- record: x402:revenue:total_by_offer_current
expr: |
sum by (offer_namespace, offer_name) (
obol_x402_verifier_charged_requests_total
Expand Down Expand Up @@ -101,11 +102,11 @@ spec:
labels:
severity: warning
annotations:
summary: "x402 payment failures > 10% on {{ $labels.offer_namespace }}/{{ $labels.offer_name }} ({{ $labels.chain }})"
summary: "x402 payment failures > 10% on {{ "{{" }} $labels.offer_namespace {{ "}}" }}/{{ "{{" }} $labels.offer_name {{ "}}" }} ({{ "{{" }} $labels.chain {{ "}}" }})"
description: |
More than 10% of paid requests to
{{ $labels.offer_namespace }}/{{ $labels.offer_name }} on
{{ $labels.chain }} have failed verification over the last
{{ "{{" }} $labels.offer_namespace {{ "}}" }}/{{ "{{" }} $labels.offer_name {{ "}}" }} on
{{ "{{" }} $labels.chain {{ "}}" }} have failed verification over the last
hour. Check the verifier logs for x509/facilitator errors and
the seller's `ca-certificates` ConfigMap.

Expand All @@ -130,10 +131,10 @@ spec:
labels:
severity: warning
annotations:
summary: "{{ $labels.offer_namespace }}/{{ $labels.offer_name }} returns 402 but never settles"
summary: "{{ "{{" }} $labels.offer_namespace {{ "}}" }}/{{ "{{" }} $labels.offer_name {{ "}}" }} returns 402 but never settles"
description: |
The x402 verifier issued 402 responses for
{{ $labels.offer_namespace }}/{{ $labels.offer_name }} in the
{{ "{{" }} $labels.offer_namespace {{ "}}" }}/{{ "{{" }} $labels.offer_name {{ "}}" }} in the
last hour but observed no settled requests. Check the buyer
sidecar's auth pool (/status) and the facilitator's settlement
endpoint.