Commit be058f6
committed
Fix: bug in JXTreeTable.getEditingRow
org.jdesktop.swingx.JXTreeTable contains the following (decompiled) methods
public boolean isHierarchical(int column) {
if (column >= 0 && column < this.getColumnCount()) {
return this.getHierarchicalColumn() == column;
} else {
throw new IllegalArgumentException("column must be valid, was" + column);
}
}
public int getEditingRow() {
if (this.editingRow == -1) {
return -1;
} else {
return this.isHierarchical(this.editingColumn) ? -1 : this.editingRow;
}
}
Exceptions are thrown, especially on macOS clients, when getEditingRow
is called while not editing, causing isHeirarchical to be called when
editingColumn is -1.
This commit overrides getEditingRow to protect against that condition.
Issue: #272
Signed-off-by: Tony Germano <tony@germano.name>1 parent be1072d commit be058f6
File tree
1 file changed
+16
-9
lines changed- client/src/com/mirth/connect/client/ui
1 file changed
+16
-9
lines changedLines changed: 16 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
9 | 4 | | |
10 | 5 | | |
11 | 6 | | |
| |||
135 | 130 | | |
136 | 131 | | |
137 | 132 | | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
138 | 145 | | |
139 | 146 | | |
140 | 147 | | |
| |||
145 | 152 | | |
146 | 153 | | |
147 | 154 | | |
148 | | - | |
| 155 | + | |
0 commit comments