Skip to content

test : added unit tests for getLinkedAccounts and getAllAccounts#795

Open
tmdeveloper007 wants to merge 4 commits into
Priyanshu-byte-coder:mainfrom
tmdeveloper007:#775
Open

test : added unit tests for getLinkedAccounts and getAllAccounts#795
tmdeveloper007 wants to merge 4 commits into
Priyanshu-byte-coder:mainfrom
tmdeveloper007:#775

Conversation

@tmdeveloper007
Copy link
Copy Markdown
Contributor

Closes #775.

Summary of What Has Been Done:
Added test/github-accounts-linked.test.ts with 10 vitest tests covering getLinkedAccounts, getAllAccounts, and getAccountToken from src/lib/github-accounts.ts.

Changes Made:
New file: test/github-accounts-linked.test.ts

Test coverage:

  • getLinkedAccounts: empty array, all fields (githubId, githubLogin, token), skips null decryption results, defaults missing fields
  • getAllAccounts: primary at index 0, filters primary from linked by githubId, linked accounts appear after primary
  • getAccountToken: valid decryption, null when account not found, null when decryption fails

Impact it Made:
All 10 tests pass. Multi-account token resolution validated.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 23, 2026

@TESTPERSONAL is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:testing GSSoC type bonus: tests (+10 pts) labels May 23, 2026
@github-actions
Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@tmdeveloper007 tmdeveloper007 force-pushed the #775 branch 2 times, most recently from fcba453 to 7d6fb44 Compare May 23, 2026 04:29
Copy link
Copy Markdown
Owner

@Priyanshu-byte-coder Priyanshu-byte-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import pattern is correct — function imported from source. Three infrastructure issues to fix before merge:

  1. Missing "test": "vitest run" in package.json scripts — tests can't run in CI without this.
  2. vitest.config.ts missing resolve.alias@/lib/* path aliases fail without:
import path from 'path'
export default defineConfig({
  resolve: { alias: { '@': path.resolve(__dirname, 'src') } },
  test: { globals: true }
})
  1. Missing EOF newline on test file.

@Priyanshu-byte-coder Priyanshu-byte-coder added gssoc:approved GSSoC: PR approved for scoring level:beginner GSSoC: Beginner difficulty (20 pts) labels May 23, 2026
@tmdeveloper007 tmdeveloper007 force-pushed the #775 branch 2 times, most recently from ab9f004 to fc6e84b Compare May 23, 2026 15:10
Test User added 4 commits May 23, 2026 23:21
Closes Priyanshu-byte-coder#775

Added test/github-accounts-linked.test.ts covering:
- getLinkedAccounts: empty array, all fields mapped, skips null decryption, defaults missing fields
- getAllAccounts: primary at index 0, filters primary from linked by githubId, linked accounts after primary
- getAccountToken: valid decryption, null on not found, null on decryption failure

Impact: All 10 tests pass. Multi-account token resolution validated.
@tmdeveloper007
Copy link
Copy Markdown
Contributor Author

This pull request is fully up-to-date with the latest upstream merges, all review items are addressed, local tests are passing cleanly, and it is fully ready to be merged! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved GSSoC: PR approved for scoring gssoc26 GSSoC 2026 contribution level:beginner GSSoC: Beginner difficulty (20 pts) type:testing GSSoC type bonus: tests (+10 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test : add unit tests for getLinkedAccounts and getAllAccounts

2 participants