Skip to content

Qua 1882 datahub integration#1128

Merged
shindiogawa merged 4 commits into
mainfrom
qua-1882-datahub-integration
May 22, 2026
Merged

Qua 1882 datahub integration#1128
shindiogawa merged 4 commits into
mainfrom
qua-1882-datahub-integration

Conversation

@shindiogawa
Copy link
Copy Markdown
Contributor

@shindiogawa shindiogawa commented May 21, 2026

Summary

Refresh the DataHub integration guide to match the current implementation, plus a small navigation cleanup.

DataHub documentation updates (docs/settings/integrations/data-catalogs/datahub.md):

  • Event Driven trigger list updated to reflect that anomaly resolution and check/scan deletion also push to DataHub.
  • What Gets Synced restructured into Pull and Push sections, with Push organized by where the data lands in DataHub (Documentation tab, Structured Properties,
    Incidents tab).
  • How Qualytics Matches Assets corrected: Datastores match to a Container with subType Schema (not Platform/Dataset), with parent-database disambiguation. Added a
    tip for instances with same-named schemas across databases.
  • Attributes Added to DataHub Assets rewritten using user-facing display names (Quality Score Total, Quality Score Completeness, ..., Active Checks, Active Anomalies,
    View in Qualytics) instead of internal qualified names.
  • What Appears at Each Level matrix added showing which surfaces (Documentation, Structured Properties, Incidents) apply at Datastore vs Container vs Field level.
  • DataHub Incidents section added covering title, description, category, priority, state, and the full raise/resolve/re-raise lifecycle.
  • When You Resolve Anomalies in Qualytics section added to highlight the auto-resolve behavior.
  • Asset Matching Example corrected (Container subType Schema, not Platform → Dataset).
  • Known Limitations and Troubleshooting rows updated to use "Structured Properties" terminology and to drop the misleading "platform" name-segment language.
  • 5 screenshots added: Documentation tab summary, Incidents tab, incident detail panel, external tag tooltip, edit-domains modal.

Navigation cleanup (mkdocs.yml):

  • Merged the leftover standalone Integrations block (SSO, Compute, Workflow, Analytics) into the Settings → Integrations section introduced by the May Settings
    refactor. Removed the duplicate top-level Integrations entry.
  • Removed the duplicate Qualytics CLI block nested inside "Using the Platform". The top-level Qualytics CLI section (with the full Setup and Examples & Use Cases
    tree) remains as the single source of truth.
  • Both changes are nav-only — file paths and URLs are unchanged, no redirects needed.

@shindiogawa shindiogawa self-assigned this May 21, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 21, 2026

Greptile Summary

This PR refreshes the DataHub integration guide to match the current implementation and cleans up duplicate navigation entries in mkdocs.yml.

  • datahub.md: Rewrites What Gets Synced into a three-surface push model (Documentation tab, Structured Properties, Incidents tab); corrects asset matching to Container subType Schema; replaces four old attribute names with 12 user-facing display names; adds a DataHub Incidents lifecycle section and a What Appears at Each Level matrix; updates Known Limitations and Troubleshooting; adds five new screenshots.
  • mkdocs.yml: Merges the orphaned top-level Integrations block (SSO, Compute, Workflow, Analytics) under Settings → Integrations, and removes a duplicate nested Qualytics CLI block — the full top-level CLI section with all pages remains intact at the root nav level.

Confidence Score: 5/5

This PR is safe to merge — all changes are documentation and navigation only, with no code execution or functional logic involved.

The datahub.md rewrite is internally consistent: the three-surface push model (Documentation, Structured Properties, Incidents) is described accurately and cross-referenced correctly across all sections. The mkdocs.yml navigation cleanup correctly removes two duplicate nav blocks while keeping the full top-level Qualytics CLI section and all 5 SSO/Compute/Workflow/Analytics pages reachable under Settings → Integrations. All five new screenshots are referenced in the markdown and present in the diff. No pages are orphaned or made unreachable.

No files require special attention.

Important Files Changed

Filename Overview
docs/settings/integrations/data-catalogs/datahub.md Comprehensive rewrite of the DataHub integration guide: updated event-driven trigger list, restructured What Gets Synced into Pull/Push with three-surface push model, corrected asset-matching explanation (Container subType Schema), replaced four old attribute names with 12 user-facing display names, added What Appears at Each Level matrix, DataHub Incidents lifecycle section, When You Resolve Anomalies section, updated Known Limitations and Troubleshooting tables, and five new screenshots. Internally consistent and accurate.
mkdocs.yml Navigation cleanup: merged the orphaned top-level Integrations block (SSO, Compute, Workflow, Analytics) under Settings → Integrations, and removed a duplicate nested Qualytics CLI block. The full top-level Qualytics CLI section with Setup, Examples & Use Cases tree is still present at line 666, so no CLI pages are removed from site navigation.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Qualytics Sync Triggered\nManual or Event Driven] --> B{Match Asset\nby qualified name}
    B -->|Datastore| C[DataHub Container\nsubType: Schema]
    B -->|Container / Table| D[DataHub Dataset]
    B -->|Field / Column| E[DataHub SchemaField]

    C --> F[Documentation Tab\nQuality summary + View in Qualytics link]
    D --> F
    D --> G[Structured Properties\n12 typed fields]
    D --> H{Active Anomalies\n> 0?}
    E --> F
    E --> G

    H -->|Yes| I[Raise Incident\nQualytics: Active Anomalies]
    H -->|No| J{Incident exists?}
    J -->|Yes| K[Resolve Incident\nautomatically ~10s]
    J -->|No| L[No action]

    M[DataHub Tags] -->|Pull via manual sync| N[Qualytics External Tags]
Loading

Reviews (3): Last reviewed commit: "Address greptile feedback" | Re-trigger Greptile

@shindiogawa
Copy link
Copy Markdown
Contributor Author

@greptile review

@shindiogawa
Copy link
Copy Markdown
Contributor Author

@greptile review

@shindiogawa shindiogawa merged commit c906894 into main May 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants