Skip to content

Commit 576cc73

Browse files
feat: explicitly disable noUncheckedSideEffectImports to accommodate (#77)
the latest TypeScript changes Previously, `noUncheckedSideEffectImports` was disabled by default in TypeScript, but it has recently been enabled by default. Since this option can break existing projects that use CSS Modules, this commit explicitly disables it to maintain the previous behavior. Ref: - microsoft/TypeScript#62443 - microsoft/typescript-go#2864
1 parent 7d0a76b commit 576cc73

6 files changed

Lines changed: 19 additions & 11 deletions

File tree

.changeset/deep-groups-attack.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
---
2+
"@robot-inventor/tsconfig-base": minor
3+
---
4+
5+
feat: explicitly disable `noUncheckedSideEffectImports` to accommodate the latest TypeScript changes
6+
7+
Previously, `noUncheckedSideEffectImports` was disabled by default in TypeScript, but it has recently been enabled by default. Since this option can break existing projects that use CSS Modules, this commit explicitly disables it to maintain the previous behavior.
8+
9+
Ref:
10+
11+
- https://github.com/microsoft/TypeScript/pull/62443
12+
- https://github.com/microsoft/typescript-go/pull/2864

bundler.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525
"allowImportingTsExtensions": true,
2626
"verbatimModuleSyntax": true,
2727
"erasableSyntaxOnly": true,
28-
"incremental": true
28+
"incremental": true,
29+
"noUncheckedSideEffectImports": false
2930
},
3031
"include": ["../../../src/**/*.ts"],
3132
"exclude": ["../../../src/**/*.test.ts"]

next.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
"jsx": "react-jsx",
2727
"erasableSyntaxOnly": true,
2828
"incremental": true,
29+
"noUncheckedSideEffectImports": false,
2930
"plugins": [
3031
{
3132
"name": "next"

package-lock.json

Lines changed: 0 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

react-emotion.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@
2828
"jsxImportSource": "@emotion/react",
2929
"types": ["@emotion/react/types/css-prop"],
3030
"erasableSyntaxOnly": true,
31-
"incremental": true
31+
"incremental": true,
32+
"noUncheckedSideEffectImports": false
3233
},
3334
"include": ["../../../src/**/*.ts", "../../../src/**/*.tsx"],
3435
"exclude": ["../../../src/**/*.test.ts"]

tsc.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@
2323
"noPropertyAccessFromIndexSignature": true,
2424
"verbatimModuleSyntax": true,
2525
"erasableSyntaxOnly": true,
26-
"incremental": true
26+
"incremental": true,
27+
"noUncheckedSideEffectImports": false
2728
},
2829
"include": ["../../../src/**/*.ts"],
2930
"exclude": ["../../../src/**/*.test.ts"]

0 commit comments

Comments
 (0)